From: blatinox@blatinox.fr
To: Sandra Loosemore <sandra@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org, Nick Clifton <nickc@redhat.com>,
Richard Earnshaw <richard.earnshaw@arm.com>,
Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>,
Kyrylo Tkachov <kyrylo.tkachov@arm.com>
Subject: Re: [PING^2][PATCH] Fix documentation of -mpoke-function-name ARM option
Date: Sun, 8 Mar 2020 18:19:54 +0100 [thread overview]
Message-ID: <20200308171954.orlmuuuh4o3btrzn@blatinox.fr> (raw)
In-Reply-To: <6293769b-1fab-1291-db79-e9d909337a2a@codesourcery.com>
Hi Sandra,
On Mon, Feb 24, 2020 at 02:19:21PM -0700, Sandra Loosemore wrote:
> On 2/20/20 3:08 PM, Jérémy Lefaure wrote:
> > Hello,
> >
> > Ping for https://gcc.gnu.org/ml/gcc-patches/2019-12/msg01081.html.
> >
> > Thank you,
> > Jérémy
> >
> > On Sun, Dec 15, 2019 at 07:20:26PM +0100, Jérémy Lefaure wrote:
> > > Hi!
> > >
> > > Since in ARM state the value of PC is the address of the current
> > > instruction plus 8 bytes, the code inspecting the value of PC stored at
> > > FP + 0 should look at location PC - 16 : PC - 8 points to the stmfd
> > > instruction, PC - 16 points two words before, where the top 8 bits are
> > > set.
> > >
> > > gcc/
> > > 2019-12-14 Jérémy Lefaure <jeremy@lefaure.fr>
> > >
> > > * config/arm/arm.c (-mpoke-function-name): Fix documentation in comment.
> > > * doc/invoke.texi (-mpoke-function-name): Fix documentation.
> > >
> >
>
> The patch looks OK to me from a documentation point of view, but I'm no
> expert about the technical correctness of the change. Maybe an ARM
> maintainer can review this?
>
Thank you for taking the time to review this patch.
I hope that an ARM maintainer will have time to review it too.
Thank you,
Jérémy
next prev parent reply other threads:[~2020-03-08 17:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-15 18:42 [PATCH] " Jérémy Lefaure
2020-01-10 10:23 ` [PING][PATCH] " Jérémy Lefaure
2020-02-20 22:08 ` [PING^2][PATCH] " Jérémy Lefaure
2020-02-24 21:19 ` Sandra Loosemore
2020-03-08 17:19 ` blatinox [this message]
2020-03-09 17:53 Wilco Dijkstra
2020-03-22 18:15 ` Jérémy Lefaure
2020-03-23 14:10 ` Richard Earnshaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200308171954.orlmuuuh4o3btrzn@blatinox.fr \
--to=blatinox@blatinox.fr \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@arm.com \
--cc=nickc@redhat.com \
--cc=ramana.radhakrishnan@arm.com \
--cc=richard.earnshaw@arm.com \
--cc=sandra@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).