From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id E3C30385E001 for ; Sun, 22 Mar 2020 19:30:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E3C30385E001 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=segher@kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 02MJUhoq002044; Sun, 22 Mar 2020 14:30:43 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 02MJUgNB002043; Sun, 22 Mar 2020 14:30:42 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Sun, 22 Mar 2020 14:30:42 -0500 From: Segher Boessenkool To: Richard Henderson Cc: gcc-patches@gcc.gnu.org, richard.earnshaw@arm.com, Wilco.Dijkstra@arm.com, marcus.shawcroft@arm.com Subject: Re: [PATCH v2 3/9] aarch64: Add cmp_*_carryinC patterns Message-ID: <20200322193042.GM22482@gate.crashing.org> References: <20200321024231.13778-1-richard.henderson@linaro.org> <20200321024231.13778-4-richard.henderson@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200321024231.13778-4-richard.henderson@linaro.org> User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-53.4 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, TXREP, T_SPF_HELO_PERMERROR, T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Mar 2020 19:31:01 -0000 Hi! On Fri, Mar 20, 2020 at 07:42:25PM -0700, Richard Henderson via Gcc-patches wrote: > Duplicate all usub_*_carryinC, but use xzr for the output when we > only require the flags output. The signed versions use sign_extend > instead of zero_extend for combine's benefit. You actually use ANY_EXTEND, which makes a lot more sense :-) Did you see combine create a sign_extend, ever? Or do those just come from combining other insns that already contain a sign_extend? Segher