From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by sourceware.org (Postfix) with ESMTPS id 578F7385B833; Fri, 3 Apr 2020 12:13:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 578F7385B833 Received: by mail-pg1-x541.google.com with SMTP id l14so3444586pgb.1; Fri, 03 Apr 2020 05:13:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=EY5tN7a8VEH/MnZuHuV1J5rprNA/YfVC9NU0J1Vbfhw=; b=O5nMcRnfa5R+2aKt1bp94HRBSXAPaSvsVuDto3Eo+V14ZNL2IQkYRn5Y53aJJUr55N v4njT9wYyYUpBBXxuKWN9r260hxR8W6tmJ0/0KAyNMYyN6y8+9/yrGdHYZYHwbjT9a0F ymXK8ZVhZDqbVJSmXUH9u5lMx2eREF0wkeHkf7Cal5tyE+Tagyw9LixD5cdk2YFpI0d8 0kxlnVBNKCUhIzlVtEcCqtm6EQSitX1p3fJUYvldyi9zpr2XsOmnONfRyRuPm10AfNVI 90wEPqNZ70U1OiW07q67I988DInurEdDMU3yW+PBjF6VtmO7oDiQPyYGIVpl9ayrWmr+ aonQ== X-Gm-Message-State: AGi0Pua2lMw7rQU2gW8md+/oojjZiMKY7bm1a7dHVDAUq7ZJB/b1ToDu foyV91LuxXvUCcTnLmkbG4AbbEzo1GM= X-Google-Smtp-Source: APiQypLGWC+Yp66qhgiYGiVktPqv39LulBKnfWBVUtyElk0uqDMIKsdUQe7c32FLCew3GAb6AG6yNg== X-Received: by 2002:a63:d50e:: with SMTP id c14mr7631536pgg.97.1585916035186; Fri, 03 Apr 2020 05:13:55 -0700 (PDT) Received: from bubble.grove.modra.org ([2406:3400:51d:8cc0:746f:405d:7daa:4a17]) by smtp.gmail.com with ESMTPSA id m14sm5780143pje.19.2020.04.03.05.13.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2020 05:13:54 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id C750A88DB1; Fri, 3 Apr 2020 22:43:49 +1030 (ACDT) Date: Fri, 3 Apr 2020 22:43:49 +1030 From: Alan Modra To: luoxhu Cc: Segher Boessenkool , wschmidt@linux.ibm.com, gcc-patches@gcc.gnu.org, linkw@gcc.gnu.org Subject: Re: [PATCH] rs6000: Don't split constant oprator when add, move to temp register for future optimization Message-ID: <20200403121349.GH4583@bubble.grove.modra.org> References: <20200326100643.32487-1-luoxhu@linux.ibm.com> <20200327143331.GD22482@gate.crashing.org> <388143a3-7889-0476-abd7-d2e9b667e5f4@linux.ibm.com> <20200402221653.GG26902@gate.crashing.org> <596ce54a-996c-3180-dbf1-df5e94ded4cb@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <596ce54a-996c-3180-dbf1-df5e94ded4cb@linux.ibm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Apr 2020 12:13:57 -0000 On Fri, Apr 03, 2020 at 02:13:06PM +0800, luoxhu via Gcc-patches wrote: > Seems PR94393? Yes, rs6000_emit_set_const calls rs6000_emit_set_long_const for DImode. > I tried unsigned long like 0xabcd87654321, 0xffffabcd87654321 and 0xc000000000000000ULL, > All of them are outside of loop even without my patch. No difference with or without > Alan's patch. Segher probably meant the part I'm working on and haven't posted yet, fixing lots of problems with rs6000_rtx_costs. One of the improvements I'm aiming for is that we should be able to emit code that loads constants from memory without following optimisation passes converting the loads from memory to those long sequences of dependent instructions. -- Alan Modra Australia Development Lab, IBM