public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jan Hubicka <hubicka@ucw.cz>
To: gcc-patches@gcc.gnu.org, mjambor@suse.cz
Subject: Disable aggregate walking in ipa code for optimize_debug
Date: Sat, 4 Apr 2020 11:58:15 +0200	[thread overview]
Message-ID: <20200404095815.GV49582@kam.mff.cuni.cz> (raw)

Martin,
with optimize_debug or when FRE is disabled propagating aggregates is
useless since we are not going to use them.  I think we should also
avoid working hard on the jump functions.
This patch disables it in ipa_load_from_param_agg, but I am not sure if
there are other ways ipa-prop can do the memory walk?

Bootstrapped/regtested x86_64. Makes sense?

Honza

	* ipa-fnsummary.c (vrp_will_run_p): Export.
	* ipa-fnsummary.h (vrp_will_run_p): Declare.
	* ipa-prop.c (ipa_load_from_parm_agg): Use it.
diff --git a/gcc/ipa-fnsummary.c b/gcc/ipa-fnsummary.c
index d96c8e9b03c..e5f43078c27 100644
--- a/gcc/ipa-fnsummary.c
+++ b/gcc/ipa-fnsummary.c
@@ -522,7 +522,7 @@ vrp_will_run_p (struct cgraph_node *node)
 
 /* Similarly about FRE.  */
 
-static bool
+bool
 fre_will_run_p (struct cgraph_node *node)
 {
   return (opt_for_fn (node->decl, optimize)
diff --git a/gcc/ipa-fnsummary.h b/gcc/ipa-fnsummary.h
index c6ddc9f3199..f4e1fd0cc86 100644
--- a/gcc/ipa-fnsummary.h
+++ b/gcc/ipa-fnsummary.h
@@ -371,6 +371,7 @@ void evaluate_properties_for_edge (struct cgraph_edge *e,
 void ipa_fnsummary_c_finalize (void);
 HOST_WIDE_INT ipa_get_stack_frame_offset (struct cgraph_node *node);
 void ipa_remove_from_growth_caches (struct cgraph_edge *edge);
+bool fre_will_run_p (struct cgraph_node *);
 
 /* Return true if EDGE is a cross module call.  */
 
diff --git a/gcc/ipa-prop.c b/gcc/ipa-prop.c
index 71ac0e104d2..7f654f3aea3 100644
--- a/gcc/ipa-prop.c
+++ b/gcc/ipa-prop.c
@@ -1091,6 +1091,12 @@ ipa_load_from_parm_agg (struct ipa_func_body_info *fbi,
   int index;
   HOST_WIDE_INT size;
   bool reverse;
+
+  /* Do not bother to do analysis when we are not doing propagation of
+     aggregates anyway.  */
+  if (!fre_will_run_p (cgraph_node::get (current_function_decl)))
+    return false;
+
   tree base = get_ref_base_and_extent_hwi (op, offset_p, &size, &reverse);
 
   if (!base)

             reply	other threads:[~2020-04-04  9:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-04  9:58 Jan Hubicka [this message]
2020-04-08 15:13 ` Martin Jambor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200404095815.GV49582@kam.mff.cuni.cz \
    --to=hubicka@ucw.cz \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=mjambor@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).