public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Fritz Reese <fritzoreese@gmail.com>
Cc: fortran <fortran@gcc.gnu.org>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: Fix an ICE found in PR93686
Date: Mon, 6 Apr 2020 14:47:33 -0700	[thread overview]
Message-ID: <20200406214733.GA91248@troutmask.apl.washington.edu> (raw)
In-Reply-To: <CAE4aFAkN85UKFqHgVZtDR61ofL4dJkb7prReOq1CeV_2-Sz-YA@mail.gmail.com>

On Mon, Apr 06, 2020 at 04:10:24PM -0400, Fritz Reese wrote:
> On Sat, Apr 4, 2020 at 2:58 PM Steve Kargl via Fortran
> <fortran@gcc.gnu.org> wrote:
> >
> > This patch fixes the ICE found in PR93686.
> >
> >
> > Index: gcc/fortran/decl.c
> > ===================================================================
> > --- gcc/fortran/decl.c  (revision 280157)
> > +++ gcc/fortran/decl.c  (working copy)
> > @@ -696,6 +696,10 @@ gfc_match_data (void)
> >           /* F2008:C567 (R536) A data-i-do-object or a variable that appears
> >              as a data-stmt-object shall not be an object designator in which
> >              a pointer appears other than as the entire rightmost part-ref.  */
> > +         if (!e->ref && e->ts.type == BT_DERIVED
> > +             && e->symtree->n.sym->attr.pointer)
> > +           goto partref;
> > +
> >           ref = e->ref;
> >           if (e->symtree->n.sym->ts.type == BT_DERIVED
> >               && e->symtree->n.sym->attr.pointer
> >
> > --
> > Steve
> 
> LGTM, thanks for the patch. I will commit along with the testcases from the PR.
> 
Thanks.  For reference, my original code did not check
the left-most partref for the pointer attribute.  This
patch implements this check.

BTW, if you haven't committed the degree trig functions, 
then I think you should to get the fixes in for 10.1.

-- 
Steve

  reply	other threads:[~2020-04-06 21:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200404185811.GA72336@troutmask.apl.washington.edu>
2020-04-06 20:10 ` Fritz Reese
2020-04-06 21:47   ` Steve Kargl [this message]
2020-04-07 15:41     ` Fritz Reese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200406214733.GA91248@troutmask.apl.washington.edu \
    --to=sgk@troutmask.apl.washington.edu \
    --cc=fortran@gcc.gnu.org \
    --cc=fritzoreese@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).