* [PATCH] RS6000: Use .machine ppc for some CRT files @ 2020-04-07 5:18 Sebastian Huber 2020-04-17 5:59 ` Sebastian Huber 2020-04-25 0:20 ` Segher Boessenkool 0 siblings, 2 replies; 6+ messages in thread From: Sebastian Huber @ 2020-04-07 5:18 UTC (permalink / raw) To: gcc-patches Since commit e154242724b084380e3221df7c08fcdbd8460674 the flag -many is sometimes not passed to the assembler. Use .machine ppc to prevent errors if these files are assembled for an ISA which does not support FPRs. libgcc/ * config/rs6000/crtresfpr.S: Use .machine ppc. * config/rs6000/crtresxfpr.S: Likewise. * config/rs6000/crtsavfpr.S: Likewise. --- libgcc/config/rs6000/crtresfpr.S | 1 + libgcc/config/rs6000/crtresxfpr.S | 1 + libgcc/config/rs6000/crtsavfpr.S | 1 + 3 files changed, 3 insertions(+) diff --git a/libgcc/config/rs6000/crtresfpr.S b/libgcc/config/rs6000/crtresfpr.S index 6c0d01bf9c1..99e6f086026 100644 --- a/libgcc/config/rs6000/crtresfpr.S +++ b/libgcc/config/rs6000/crtresfpr.S @@ -27,6 +27,7 @@ /* Do any initializations needed for the eabi environment */ + .machine ppc .section ".text" #include "ppc-asm.h" diff --git a/libgcc/config/rs6000/crtresxfpr.S b/libgcc/config/rs6000/crtresxfpr.S index 9f01fa5094b..9931db244f7 100644 --- a/libgcc/config/rs6000/crtresxfpr.S +++ b/libgcc/config/rs6000/crtresxfpr.S @@ -27,6 +27,7 @@ /* Do any initializations needed for the eabi environment */ + .machine ppc .section ".text" #include "ppc-asm.h" diff --git a/libgcc/config/rs6000/crtsavfpr.S b/libgcc/config/rs6000/crtsavfpr.S index fa043ddd078..dd8743ae058 100644 --- a/libgcc/config/rs6000/crtsavfpr.S +++ b/libgcc/config/rs6000/crtsavfpr.S @@ -27,6 +27,7 @@ /* Do any initializations needed for the eabi environment */ + .machine ppc .section ".text" #include "ppc-asm.h" -- 2.16.4 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] RS6000: Use .machine ppc for some CRT files 2020-04-07 5:18 [PATCH] RS6000: Use .machine ppc for some CRT files Sebastian Huber @ 2020-04-17 5:59 ` Sebastian Huber 2020-04-24 20:55 ` Segher Boessenkool 2020-04-24 21:47 ` Peter Bergner 2020-04-25 0:20 ` Segher Boessenkool 1 sibling, 2 replies; 6+ messages in thread From: Sebastian Huber @ 2020-04-17 5:59 UTC (permalink / raw) To: gcc-patches; +Cc: Segher Boessenkool Hello Segher, would you mind having a look at this patch. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] RS6000: Use .machine ppc for some CRT files 2020-04-17 5:59 ` Sebastian Huber @ 2020-04-24 20:55 ` Segher Boessenkool 2020-04-24 21:47 ` Peter Bergner 1 sibling, 0 replies; 6+ messages in thread From: Segher Boessenkool @ 2020-04-24 20:55 UTC (permalink / raw) To: Sebastian Huber; +Cc: gcc-patches On Fri, Apr 17, 2020 at 07:59:02AM +0200, Sebastian Huber wrote: > would you mind having a look at this patch. Hi! I see no patch? Segher ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] RS6000: Use .machine ppc for some CRT files 2020-04-17 5:59 ` Sebastian Huber 2020-04-24 20:55 ` Segher Boessenkool @ 2020-04-24 21:47 ` Peter Bergner 2020-04-25 0:15 ` Segher Boessenkool 1 sibling, 1 reply; 6+ messages in thread From: Peter Bergner @ 2020-04-24 21:47 UTC (permalink / raw) To: Segher Boessenkool; +Cc: Sebastian Huber, gcc-patches On 4/17/20 12:59 AM, Sebastian Huber wrote: > Hello Segher, > > would you mind having a look at this patch. > His patch is here: https://gcc.gnu.org/pipermail/gcc-patches/2020-April/543396.html Peter ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] RS6000: Use .machine ppc for some CRT files 2020-04-24 21:47 ` Peter Bergner @ 2020-04-25 0:15 ` Segher Boessenkool 0 siblings, 0 replies; 6+ messages in thread From: Segher Boessenkool @ 2020-04-25 0:15 UTC (permalink / raw) To: Peter Bergner; +Cc: Sebastian Huber, gcc-patches On Fri, Apr 24, 2020 at 04:47:31PM -0500, Peter Bergner wrote: > On 4/17/20 12:59 AM, Sebastian Huber wrote: > > Hello Segher, > > > > would you mind having a look at this patch. > > > > His patch is here: > > https://gcc.gnu.org/pipermail/gcc-patches/2020-April/543396.html (And at https://patchwork.ozlabs.org/project/gcc/patch/20200407051825.12516-1-sebastian.huber@embedded-brains.de/ where you can see headers as well). Ah, I wasn't Cc:ed, and I don't have a regexp for "RS6000" :-) Segher ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] RS6000: Use .machine ppc for some CRT files 2020-04-07 5:18 [PATCH] RS6000: Use .machine ppc for some CRT files Sebastian Huber 2020-04-17 5:59 ` Sebastian Huber @ 2020-04-25 0:20 ` Segher Boessenkool 1 sibling, 0 replies; 6+ messages in thread From: Segher Boessenkool @ 2020-04-25 0:20 UTC (permalink / raw) To: Sebastian Huber; +Cc: gcc-patches Hi! On Tue, Apr 07, 2020 at 07:18:25AM +0200, Sebastian Huber wrote: > Since commit e154242724b084380e3221df7c08fcdbd8460674 the flag -many is > sometimes not passed to the assembler. Use .machine ppc to prevent > errors if these files are assembled for an ISA which does not support > FPRs. > > libgcc/ > > * config/rs6000/crtresfpr.S: Use .machine ppc. > * config/rs6000/crtresxfpr.S: Likewise. > * config/rs6000/crtsavfpr.S: Likewise. This is fine. Okay for trunk. Thank you! Also okay for backports if you want -- after letting it simmer on trunk for a week or so. Segher ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-25 0:20 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-04-07 5:18 [PATCH] RS6000: Use .machine ppc for some CRT files Sebastian Huber 2020-04-17 5:59 ` Sebastian Huber 2020-04-24 20:55 ` Segher Boessenkool 2020-04-24 21:47 ` Peter Bergner 2020-04-25 0:15 ` Segher Boessenkool 2020-04-25 0:20 ` Segher Boessenkool
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).