From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id D73823938C05 for ; Tue, 19 May 2020 09:24:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D73823938C05 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-2-m_feVsbPPRyb1DO50Mvx5w-1; Tue, 19 May 2020 05:24:47 -0400 X-MC-Unique: m_feVsbPPRyb1DO50Mvx5w-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D0CFA83DE2D; Tue, 19 May 2020 09:24:38 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-112-94.ams2.redhat.com [10.36.112.94]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5E816196AE; Tue, 19 May 2020 09:24:38 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id 04J9OYvb006200; Tue, 19 May 2020 11:24:35 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id 04J9OXaQ006199; Tue, 19 May 2020 11:24:33 +0200 Date: Tue, 19 May 2020 11:24:33 +0200 From: Jakub Jelinek To: Kito Cheng Cc: gcc-patches@gcc.gnu.org, kito.cheng@gmail.com Subject: Re: [PATCH] testsuite: Match ASCII color code for ubsan's test pattern. Message-ID: <20200519092433.GU8462@tucnak> Reply-To: Jakub Jelinek References: <20200519091339.84684-1-kito.cheng@sifive.com> MIME-Version: 1.0 In-Reply-To: <20200519091339.84684-1-kito.cheng@sifive.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 May 2020 09:24:52 -0000 On Tue, May 19, 2020 at 05:13:39PM +0800, Kito Cheng wrote: > Run gcc testsuite with qemu will print out ascii color code like that: > > ^[[1mc-c++-common/ubsan/builtin-1.c:11:10:^[[1m^[[31m runtime error: ^[[1m^[[0m^[[1mpassing zero to ctz(), which is not a valid argument^[[1m^[[0m^M > > But the match logic in some testcase e.g c-c++-common/ubsan/builtin-1.c, didn't > consider that: > > (\[^\n\r]*runtime error: passing zero to ctz\\\(\\\), which is not a valid argument\[^\n\r]*(\n|\r\n|\r)){4} > > - Verified on native X86 and RISC-V qemu full system mode and user mode. s/Ditoo/Ditto/g I think I'd prefer instead exporting some env var for all the ubsan tests in ubsan.exp that would disable the colorization. Jakub