From: Segher Boessenkool <segher@kernel.crashing.org>
To: "Yangfei (Felix)" <felix.yang@huawei.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"Zhanghaijian (A)" <z.zhanghaijian@huawei.com>
Subject: Re: [PATCH PR94026] combine missed opportunity to simplify comparisons with zero
Date: Sat, 23 May 2020 09:57:27 -0500 [thread overview]
Message-ID: <20200523145727.GA31009@gate.crashing.org> (raw)
In-Reply-To: <DA41BE1DDCA941489001C7FBD7A8820EE7DED38F@dggeml527-mbx.china.huawei.com>
Hi!
Sorry this is taking so long.
On Wed, May 06, 2020 at 08:57:52AM +0000, Yangfei (Felix) wrote:
> > On Tue, Mar 24, 2020 at 06:30:12AM +0000, Yangfei (Felix) wrote:
> > > I modified combine emitting a simple AND operation instead of making one
> > zero_extract for this scenario.
> > > Attached please find the new patch. Hope this solves both of our concerns.
> >
> > This looks promising. I'll try it out, see what it does on other targets. (It will
> > have to wait for GCC 11 stage 1, of course).
It creates better code on all targets :-) A quite small improvement, but
not entirely trivial.
> > p.s. Please use a correct mime type? application/octet-stream isn't
> > something I can reply to. Just text/plain is fine :-)
>
> I have using plain text now, hope that works for you. :-)
Nope:
[-- Attachment #2: pr94026-v2.diff --]
[-- Type: application/octet-stream, Encoding: base64, Size: 5.9K --]
Segher
next prev parent reply other threads:[~2020-05-23 14:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 8:39 Yangfei (Felix)
2020-03-05 15:37 ` Jeff Law
2020-03-06 1:01 ` Yangfei (Felix)
2020-03-12 23:50 ` Segher Boessenkool
2020-03-13 3:21 ` Yangfei (Felix)
2020-03-13 16:07 ` Segher Boessenkool
2020-03-16 6:29 ` Yangfei (Felix)
2020-03-16 17:58 ` Segher Boessenkool
2020-03-17 2:05 ` Yangfei (Felix)
2020-03-18 23:51 ` Segher Boessenkool
2020-03-19 1:43 ` Yangfei (Felix)
2020-03-20 1:38 ` Segher Boessenkool
2020-03-23 7:46 ` Yangfei (Felix)
2020-03-23 12:09 ` Segher Boessenkool
2020-03-24 6:30 ` Yangfei (Felix)
2020-03-24 14:58 ` Segher Boessenkool
2020-05-06 8:57 ` Yangfei (Felix)
2020-05-07 16:51 ` Segher Boessenkool
2020-05-23 14:57 ` Segher Boessenkool [this message]
2020-05-25 2:59 ` Yangfei (Felix)
2020-05-25 16:26 ` Segher Boessenkool
2020-05-26 3:45 ` Yangfei (Felix)
2020-05-26 15:31 ` Segher Boessenkool
2020-05-27 3:51 ` Yangfei (Felix)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200523145727.GA31009@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=felix.yang@huawei.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=z.zhanghaijian@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).