From: Jonathan Wakely <jwakely@redhat.com>
To: "François Dumont" <frs.dumont@gmail.com>
Cc: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Extend std::copy/std::copy_n char* overload to deque iterator
Date: Tue, 2 Jun 2020 21:15:10 +0100 [thread overview]
Message-ID: <20200602201510.GJ2678@redhat.com> (raw)
In-Reply-To: <ac2d29f6-6b61-4243-ffa4-d975b38cadbe@gmail.com>
On 24/05/20 15:43 +0200, François Dumont via Libstdc++ wrote:
>Now tested in C++98 mode, there was indeed a small problem.
>
>I even wonder if I shouldn't have extend the std::copy overload to any
>call with deque iterator as the output so that it is transform into an
>output to pointer.
>
>Ok to commit ?
>--- a/libstdc++-v3/include/debug/safe_iterator.tcc
>+++ b/libstdc++-v3/include/debug/safe_iterator.tcc
>@@ -234,6 +234,12 @@ namespace std _GLIBCXX_VISIBILITY(default)
> {
> _GLIBCXX_BEGIN_NAMESPACE_VERSION
>
>+ template<typename _Ite, typename _Seq>
>+ _Ite
>+ __niter_base(const ::__gnu_debug::_Safe_iterator<_Ite, _Seq,
>+ std::random_access_iterator_tag>& __it)
>+ { return __it.base(); }
>+
I was going to ask if there's a reason this uses "_Ite" and not
"_Iter", but I see we already have several uses of that.
Thy all seem to be introduced by you though :-)
We definitely have a lot more "_Iter" uses though:
$ git grep -w _Ite -- include/ | wc -l
46
$ git grep -w _Iter -- include/ | wc -l
835
When I see "Ite" it looks to me as though it should rhyme with "sight"
or "white", rather than "Iter" which rhymes with "bitter" (and so is
the start of "iterator").
Leave it as _Ite for now, I might go through and change every _Ite to
_Iter later.
OK for master, thanks.
prev parent reply other threads:[~2020-06-02 20:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 7:12 François Dumont
2020-05-15 5:17 ` François Dumont
2020-05-19 19:12 ` François Dumont
2020-05-21 12:17 ` Jonathan Wakely
2020-05-22 20:57 ` François Dumont
2020-05-23 14:02 ` François Dumont
2020-05-23 16:37 ` Jonathan Wakely
2020-05-24 13:43 ` François Dumont
2020-05-26 11:45 ` François Dumont
2020-06-02 14:20 ` François Dumont
2020-06-02 20:15 ` Jonathan Wakely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602201510.GJ2678@redhat.com \
--to=jwakely@redhat.com \
--cc=frs.dumont@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).