Re: [PATCH 1/7] PowerPC tests: Add prefixed/pcrel tests.

[Segher Boessenkool <segher@kernel.crashing.org>]

Hi!

On Mon, Jun 01, 2020 at 03:53:36PM -0400, Michael Meissner wrote:
> +# Return 1 if the target generates PC-relative instructions automatically for
> +# the PowerPC 'future' machine.

"... automatically, for configurations that allow it"?

If the selector was only for the "future" target, that should be part of
the name; but it is not, that is just a detail of the actual test.

> +proc check_effective_target_powerpc_pcrel { } {
> +    return [check_no_messages_and_pattern powerpc_pcrel \
> +	{\mpla\M} assembly {
> +	    static unsigned short s;
> +	    unsigned short *p_foo (void) { return &s; }
> +	} {-O2 -mcpu=future}]
> +}


> +# Return 1 if the target generates prefixed instructions automatically for the
> +# PowerPC 'future' machine.

Same here.

(It is important that the description for each selector is clear and
accurate, and guides the potential user to what selector to use where).

Okay for trunk with that changed.  Thanks!


Segher