From: Pierre-Marie de Rodat <derodat@adacore.com>
To: gcc-patches@gcc.gnu.org
Cc: Eric Botcazou <ebotcazou@adacore.com>
Subject: [Ada] Fix small fallout of previous change for Analyze_Selected_Component
Date: Fri, 19 Jun 2020 04:28:34 -0400 [thread overview]
Message-ID: <20200619082834.GA31424@adacore.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 538 bytes --]
The removal of the obsolete code path originally implemented for ASIS
has exposed a latent issue for components of discriminated tagged types
in instance bodies: Is_Visible_Component can wrongly return false for
them even though the ancestor type is perfectly visible in the instance.
No functional changes.
Tested on x86_64-pc-linux-gnu, committed on trunk
2020-06-19 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* sem_ch3.adb (Is_Visible_Component): Reason only on the private
status of the original type in an instance body.
[-- Attachment #2: patch.diff --]
[-- Type: text/x-diff, Size: 1352 bytes --]
--- gcc/ada/sem_ch3.adb
+++ gcc/ada/sem_ch3.adb
@@ -18864,7 +18864,9 @@ package body Sem_Ch3 is
-- a component in a sibling package that is inherited from a visible
-- component of a type in an ancestor package; the component in the
-- sibling package should not be visible even though the component it
- -- inherited from is visible). This does not apply however in the case
+ -- inherited from is visible), but instance bodies are not subject to
+ -- this second case since they have the Has_Private_View mechanism to
+ -- ensure proper visibility. This does not apply however in the case
-- where the scope of the type is a private child unit, or when the
-- parent comes from a local package in which the ancestor is currently
-- visible. The latter suppression of visibility is needed for cases
@@ -18874,7 +18876,8 @@ package body Sem_Ch3 is
or else
(not Is_Private_Descendant (Type_Scope)
and then not In_Open_Scopes (Type_Scope)
- and then Has_Private_Declaration (Original_Type))
+ and then Has_Private_Declaration (Original_Type)
+ and then not In_Instance_Body)
then
-- If the type derives from an entity in a formal package, there
-- are no additional visible components.
reply other threads:[~2020-06-19 8:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200619082834.GA31424@adacore.com \
--to=derodat@adacore.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).