From: Segher Boessenkool <segher@kernel.crashing.org>
To: Peter Bergner <bergner@linux.ibm.com>
Cc: Bill Schmidt <wschmidt@linux.ibm.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
David Edelsohn <dje.gcc@gmail.com>,
Michael Meissner <meissner@linux.ibm.com>
Subject: Re: [PATCH 0/3, v2] rs6000: Add support for Matrix-Multiply Assist (MMA) built-in functions.
Date: Wed, 24 Jun 2020 14:37:19 -0500 [thread overview]
Message-ID: <20200624193719.GF31009@gate.crashing.org> (raw)
In-Reply-To: <48810cef-d243-ba40-9157-596b9f749e6f@linux.ibm.com>
Hi!
On Wed, Jun 24, 2020 at 02:28:00PM -0500, Peter Bergner via Gcc-patches wrote:
> On 6/18/20 3:42 PM, Peter Bergner wrote:
> > POWER ISA 3.1 added new Matrix-Multiply Assist (MMA) instructions.
> > The following patch set adds support for generating these instructions
> > through built-in functions which are enabled with the -mmma option.
> >
> > The patch1 and patch1+patch2+patch3 have been bootstrapped and regtested on
> > powerpc64le-linux with no regressions. In addition, patch1+patch2+patch3
> > has been bootstrapped and regtested on powerpc64-linux (BE), also without
> > regressions. I'll note that I split the testsuite changes into their own
> > patch for review purposes, but I plan on committing patch2 and patch3 together.
> >
> > Changes since v1:
> > Patch 1/3:
> > - Modified verbiage in mma.md per Will's suggestion.
> > - Modified rs6000_split_multireg_move to correctly handle BE PXImode
> > and POImode moves.
> > Patch 2/3:
> > - Updated ChangeLog entry per Segher's suggestion.
> > - Updated doc/extend.texi with correct built-in names for
> > __builtin_vsx_xvcvspbf16 and __builtin_vsx_xvcvbf16sp.
> > Patch 3/3:
> > - No changes.
>
> The committed patches don't seem to have caused any bootstrap issues on trunk
> and are pretty independent of the rest of the rs6000 backend, so I'd like
> permission to back port the two commits to GCC 10. Patch 2 makes used of
> the u8bit_cint_operand predicate which Kelvin added, but that isn't in GCC 10,
> so I need to back port that change too.
>
> The back ports of the MMA patches/commits was straight forward and I'm
> currently bootstrapping/regtesting the backports on both powerpc64le-linux
> and powerpc64-linux. Is this (including the hunk below) ok for GCC 10
> release branch assuming the tests come back clean?
Yes, all are okay for 10 as well (incl. Kelvin's backport). Thanks!
> rs6000: Backport u8bit_cint_operand predicate.
(No dot at the end of the subject please.)
Segher
next prev parent reply other threads:[~2020-06-24 19:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 20:42 Peter Bergner
2020-06-18 20:44 ` [PATCH 1/3, v2] rs6000: Add base support and types for defining MMA built-ins Peter Bergner
2020-06-18 23:44 ` Segher Boessenkool
2020-06-19 16:47 ` Peter Bergner
2020-06-19 18:12 ` Segher Boessenkool
2020-06-19 19:33 ` Peter Bergner
2020-06-19 19:43 ` Peter Bergner
2020-06-19 22:38 ` Segher Boessenkool
2020-06-21 5:45 ` Peter Bergner
2020-06-18 20:45 ` [PATCH 2/3, v2] rs6000: Add MMA built-in function definitions Peter Bergner
2020-06-19 16:45 ` Segher Boessenkool
2020-06-19 17:06 ` Peter Bergner
2020-06-21 5:49 ` Peter Bergner
2020-06-18 20:46 ` [PATCH 3/3, v2] rs6000: Add testsuite test cases for MMA built-ins Peter Bergner
2020-06-19 16:53 ` Segher Boessenkool
2020-06-21 5:50 ` Peter Bergner
2020-06-24 19:28 ` [PATCH 0/3, v2] rs6000: Add support for Matrix-Multiply Assist (MMA) built-in functions Peter Bergner
2020-06-24 19:37 ` Segher Boessenkool [this message]
2020-06-25 13:15 ` Peter Bergner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200624193719.GF31009@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=meissner@linux.ibm.com \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).