From: Segher Boessenkool <segher@kernel.crashing.org>
To: luoxhu <luoxhu@linux.ibm.com>
Cc: gcc-patches@gcc.gnu.org, dje.gcc@gmail.com,
wschmidt@linux.ibm.com, guojiufu@linux.ibm.com,
linkw@gcc.gnu.org
Subject: Re: [PATCH] rs6000: Define movsf_from_si2 to extract high part SF element from DImode[PR89310]
Date: Fri, 10 Jul 2020 19:54:38 -0500 [thread overview]
Message-ID: <20200711005438.GE30544@gate.crashing.org> (raw)
In-Reply-To: <472e0dc4-6fc6-8d0b-2c0c-259dccd29a89@linux.ibm.com>
Hi!
On Fri, Jul 10, 2020 at 09:39:40AM +0800, luoxhu wrote:
> OK, seems the md file needs a format tool too...
Heh. Just make sure it looks good (that is, does what it looks like),
looks like the rest, etc. It's hard to do anything nice with unspecs,
[ ] lists do not format well.
> >> + "TARGET_NO_SF_SUBREG"
> >> + "#"
> >> + "&& vsx_reg_sfsubreg_ok (operands[0], SFmode)"
> >
> > Put this in the insn condition? And since this is just a predicate,
> > you can just use it instead of gpc_reg_operand.
> >
> > (The split condition becomes "&& 1" then, not "").
>
> OK, this seems a bit strange as movsi_from_sf, movsf_from_si and
> movdi_from_sf_zero_ext all use it as condition...
Since in your case you *always* split, the split condition should be
"always". There are no alternatives that do not split here.
> And why vsx_reg_sfsubreg_ok allows "SF SUBREGS" and TARGET_NO_SF_SUBREG
> "avoid (SUBREG:SF (REG:SI)", I guess they are not the same meaning? (The
> TARGET_NO_SF_SUBREG is also copied from other similar defines.) Thanks.
Good question. I do not know.
Well... Since this define_insn* requires p8 *anyway*, we do not need
any of these sf_subreg things? We always know for each one if it should
be true or false.
> + "TARGET_NO_SF_SUBREG"
But here we should require p8 some other way, then.
> + (set_attr "isa" "p8v")])
(This isn't enough, unfortunately).
Segher
next prev parent reply other threads:[~2020-07-11 0:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 2:17 [PATCH] rs6000: Split movsf_from_si from high word before reload[PR89310] Xionghu Luo
2020-07-07 0:18 ` Segher Boessenkool
2020-07-07 8:39 ` luoxhu
2020-07-07 21:31 ` Segher Boessenkool
2020-07-08 3:19 ` luoxhu
2020-07-08 22:43 ` Segher Boessenkool
2020-07-09 3:09 ` luoxhu
2020-07-09 19:25 ` Segher Boessenkool
2020-07-10 1:39 ` [PATCH] rs6000: Define movsf_from_si2 to extract high part SF element from DImode[PR89310] luoxhu
2020-07-11 0:54 ` Segher Boessenkool [this message]
2020-07-13 6:30 ` luoxhu
2020-07-14 14:17 ` David Edelsohn
2020-07-15 3:47 ` luoxhu
2020-07-20 15:31 ` Segher Boessenkool
2020-07-21 3:43 ` luoxhu
2020-07-10 7:41 ` [PATCH] rs6000: Split movsf_from_si from high word before reload[PR89310] luoxhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200711005438.GE30544@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=guojiufu@linux.ibm.com \
--cc=linkw@gcc.gnu.org \
--cc=luoxhu@linux.ibm.com \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).