From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id CE12A3861838 for ; Mon, 13 Jul 2020 12:04:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CE12A3861838 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=segher@kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 06DC4Tub025403; Mon, 13 Jul 2020 07:04:29 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 06DC4S83025402; Mon, 13 Jul 2020 07:04:28 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Mon, 13 Jul 2020 07:04:28 -0500 From: Segher Boessenkool To: Carl Love Cc: dje.gcc@gmail.com, gcc-patches@gcc.gnu.org, Will Schmidt , Bill Schmidt Subject: Re: [PATCH 0/6 ver 4] ] Permute Class Operations Message-ID: <20200713120428.GH30544@gate.crashing.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, TXREP, T_SPF_HELO_PERMERROR, T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Jul 2020 12:04:32 -0000 Hi! On Wed, Jul 08, 2020 at 12:59:00PM -0700, Carl Love wrote: > [PATCH 2/6] rs6000 Add vector insert builtin support > +For little-endian, > +the generated code will be semantically equivalent to vinsbrx, vinshrx, > +or vinswrx instructions. Similarly for big-endian it will be semantically > +equivalent to vinsblx, vinshlx, vinswlx. "This builtin generates vins[bhw]lx on BE" etc.? > Note that some > +fairly anomalous results can be generated if the byte index is not aligned > +on an element boundary for the sort of element being inserted. This is a > +limitation of the bi-endian vector programming model. Yeah, leave this out, like Will says? (Also, two spaces after dot.) > +For little-endian, the code generation will be semantically equivalent to > +vins*lx, while for big-endian it will be semantically equivalent to vins*rx. Similar / same as above. This is okay for trunk (with that improved a bit, also the typos and other doc things Will found). Thanks! Segher