From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id F13FF3857C6E for ; Tue, 21 Jul 2020 23:12:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F13FF3857C6E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=segher@kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 06LNCEH8025086; Tue, 21 Jul 2020 18:12:14 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 06LNC68Q025071; Tue, 21 Jul 2020 18:12:06 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Tue, 21 Jul 2020 18:12:06 -0500 From: Segher Boessenkool To: David Edelsohn Cc: Xiong Hu Luo , GCC Patches , Bill Schmidt , Richard Sandiford , Daniel Berlin , Jakub Jelinek Subject: Re: [PATCH] dse: Remove partial load after full store for high part access[PR71309] Message-ID: <20200721231206.GT30544@gate.crashing.org> References: <20200721105427.15217-1-luoxhu@linux.ibm.com> <20200721215443.GQ30544@gate.crashing.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, TXREP, T_SPF_HELO_PERMERROR, T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jul 2020 23:12:26 -0000 On Tue, Jul 21, 2020 at 06:37:29PM -0400, David Edelsohn wrote: > On Tue, Jul 21, 2020 at 5:54 PM Segher Boessenkool > wrote: > > always (the target cannot run the resulting code, but we have many other > > options like that, starting with -mcpu=). David, what is your > > preference? > > > > The rs6000 parts of this patch are fine for trunk. Thanks! > > There already is a { target be } selector. This set of testcases > shouldn't be limited to powerpc-linux. Ideally the scan-assembler > strings should have "be" and "le" versions to confirm the correct > results for either. There are some testcases that are really just for BE (or LE); but yeah, we can just not scan the assembler on the oppositely endianed targets. Very few tests are run tests that only work on one endianness, but that is easy to adjust to as well (wrap some #ifdef around it), and infrequent enough. Okay, thanks, I worry too much :-) Segher