From: Jakub Jelinek <jakub@redhat.com>
To: GT <tnggil@protonmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"segher@kernel.crashing.org" <segher@kernel.crashing.org>,
"dje.gcc@gmail.com" <dje.gcc@gmail.com>,
"wschmidt@linux.ibm.com" <wschmidt@linux.ibm.com>,
"tuliom@linux.ibm.com" <tuliom@linux.ibm.com>,
Bert Tenjy <tnggil@gmail.com>
Subject: Re: [RFC PATCH v1 1/1] PPC64: Implement POWER Architecture Vector Function ABI.
Date: Mon, 10 Aug 2020 20:07:25 +0200 [thread overview]
Message-ID: <20200810180725.GA2363@tucnak> (raw)
In-Reply-To: <qcx7kliBQxlzRltWEwtIagQWfDk1XnH7NYQZFAebDr9VmbL3P_U_TkOjuXZWRFsVmovZkw1zdHP-dHh1q-KerjyH9VG1-D1aAE5UnTYGhwM=@protonmail.com>
On Mon, Aug 10, 2020 at 05:29:49PM +0000, GT wrote:
> > For PowerPC, if all you want to support is b which requires VSX, then the
> > right thing is for !TREE_PUBLIC functions return 0 if !TARGET_VSX and
> > otherwise set vecsize_mangle to 'b' and in the end return 1, for exported
> > functions always set it to 'b' (and in the end return 1).
> > Then ensure that the 'b' variants of function definitions get target ("vsx")
> > attribute added if !TARGET_VSX.
> >
>
> So setting attribute "vsx" for 'b' variants of function definitions is what
> should go in function rs6000_simd_clone_usable?
No. That function should say if the particular clone ('b' in this case) is
usable from some caller, and the answer for your 'b' is TARGET_VSX is
required to be non-zero.
The adjustment should go into the simd_clone_adjust target hook, see
what ix86_simd_clone_adjust does (though, that one has more variants to
handle).
Jakub
next prev parent reply other threads:[~2020-08-10 18:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 20:35 Bert Tenjy
2020-08-07 20:59 ` Jakub Jelinek
2020-08-10 17:29 ` GT
2020-08-10 18:07 ` Jakub Jelinek [this message]
2020-08-13 20:40 ` GT
2020-08-13 21:00 ` Jakub Jelinek
2020-08-20 19:31 ` GT
2020-08-20 20:04 ` Jakub Jelinek
2020-08-20 20:29 ` Segher Boessenkool
2020-08-13 22:49 ` Segher Boessenkool
2020-08-17 17:44 ` GT
2020-08-17 21:28 ` Segher Boessenkool
2020-08-18 19:14 ` GT
2020-08-18 21:32 ` Segher Boessenkool
2020-08-20 16:19 ` GT
2020-08-20 17:48 ` Segher Boessenkool
2020-12-04 18:28 ` GT
2020-08-17 22:05 ` David Edelsohn
2020-08-17 23:06 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200810180725.GA2363@tucnak \
--to=jakub@redhat.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=segher@kernel.crashing.org \
--cc=tnggil@gmail.com \
--cc=tnggil@protonmail.com \
--cc=tuliom@linux.ibm.com \
--cc=wschmidt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).