From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by sourceware.org (Postfix) with ESMTPS id 65E813857C40 for ; Wed, 12 Aug 2020 04:02:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 65E813857C40 Received: by mail-pj1-x1030.google.com with SMTP id kr4so469656pjb.2 for ; Tue, 11 Aug 2020 21:02:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NLFhsGm3Q3P0R901NDXThurCwiYLTdz9Ln1xf81uhzs=; b=NrNf3WSK3FahRDOv4fPBiUjHlJwD6Jy4Gd8ztKr0+PquNFnyZXm1IlbzBtB2Yxyy4t QjkteaBbFRaXzySToZL7Ef8aIo16hLPm0FX71g7fG0LPk38BPxRGkjZfkRp0DiUbK5Ax EDrB9AcS9td+RJVA5+jrM+hRIeFAN8YxYuPQwYtd+J4u+Iim16O+lCUdlDqx87pRQ8lr xvd4ISOrRyZLA+RHyQyhAJKw2LHKXllTFsmvJLmSdJ5NIbZ0vC/C+LD2LSxuLw+VJpft vUj4a0wLWjM04n0ZANItldc7H3KbCPnzfngKvyMJnqLUw+Mh098R+n+3CFEMwUKavQ/Q SceA== X-Gm-Message-State: AOAM532+ipqo6TEnIOtyXExjqitnFnUrttstx0PE3IKWP4fyeRGMx7Eb bITpBAJ9uA5KajRfh/ZQ9IZEBJZinDk= X-Google-Smtp-Source: ABdhPJyJSV4dx2NBH+UDsqhck9oWUrIecitOGal0FYiFI3WAsGYPWDDZWuyjUL6ElHY7VwWigaLktw== X-Received: by 2002:a17:90a:e643:: with SMTP id ep3mr4371530pjb.18.1597204951167; Tue, 11 Aug 2020 21:02:31 -0700 (PDT) Received: from bubble.grove.modra.org ([2406:3400:51d:8cc0:24a0:3e8e:4033:7c09]) by smtp.gmail.com with ESMTPSA id l17sm641889pff.126.2020.08.11.21.02.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2020 21:02:30 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id B3B4380CF7; Wed, 12 Aug 2020 13:32:26 +0930 (ACST) Date: Wed, 12 Aug 2020 13:32:26 +0930 From: Alan Modra To: Segher Boessenkool Cc: Peter Bergner , gcc-patches@gcc.gnu.org Subject: Re: [RS6000] PR96493, powerpc local call linkage failure Message-ID: <20200812040226.GV15695@bubble.grove.modra.org> References: <20200806132818.GF15695@bubble.grove.modra.org> <20200806223403.GX6753@gate.crashing.org> <20200807032808.GI15695@bubble.grove.modra.org> <20200811090853.GT15695@bubble.grove.modra.org> <20200811163528.GI6753@gate.crashing.org> <20200811183036.GK6753@gate.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200811183036.GK6753@gate.crashing.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Aug 2020 04:02:33 -0000 On Tue, Aug 11, 2020 at 01:30:36PM -0500, Segher Boessenkool wrote: > Either always running or what this patch does will work. But please add > comments what the test case wants to test, That's already in the testcase. /* Test local calls between pcrel and non-pcrel code. The comment goes on to say Despite the cpu=power10 option, the code generated here should just be plain powerpc64, even the necessary linker stubs. */ which was the justification for using "dg-do run" unqualified in the current testcase. > and for the tricky bits. There aren't any. And other tests use multiple dg-do lines, eg. gcc/testsuite/g++.dg/ext/altivec-3.C /* { dg-do run { target { powerpc*-*-* && vmx_hw } } } */ /* { dg-do compile { target { powerpc*-*-* && { ! vmx_hw } } } } */ Committed 2ba0674c657, and apologies for missing the power10_ok first time around on this test. -- Alan Modra Australia Development Lab, IBM