From: Segher Boessenkool <segher@kernel.crashing.org>
To: Carl Love <cel@us.ibm.com>
Cc: dje.gcc@gmail.com, gcc-patches@gcc.gnu.org,
Will Schmidt <will_schmidt@vnet.ibm.com>,
Bill Schmidt <wschmidt@linux.vnet.ibm.com>,
cel@ibm.com
Subject: Re: [Patch 1/5] rs6000, Add 128-bit sign extension support
Date: Thu, 13 Aug 2020 12:36:05 -0500 [thread overview]
Message-ID: <20200813173605.GG6753@gate.crashing.org> (raw)
In-Reply-To: <4ebaa81cef8cd6fe8caf8c33d6a4fc8a946c591f.camel@us.ibm.com>
Hi!
On Tue, Aug 11, 2020 at 12:22:37PM -0700, Carl Love wrote:
> +/* Sign extend builtins that work on ISA 3.0, but not defined until ISA 3.1. */
What does this mean? Not defined in GCC before now? Does it need
backporting? Not defined in older versions of the ELFv2 ABI (or vector
doc) and we do not want a backport?
> + /* Sign extend builtins that work work on ISA 3.0, not added until ISA 3.1 */
Same (also "work work").
> +uThe following sign extension builtins are provided.
(stray "u")
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/powerpc/p9-sign_extend-runnable.c
> @@ -0,0 +1,128 @@
> +/* { dg-do run { target { powerpc*-*-linux* && { lp64 && p9vector_hw } } } } */
/* { dg-do run { target { lp64 && p9vector_hw } } } */
or such; or do you require Linux actually?
> +/* { dg-options "-O2 -mdejagnu-cpu=power9 -save-temps" } */
Is -save-temps needed? Not for the scan-assembler at least.
Okay for trunk with those details take care of. Thanks!
Segher
next prev parent reply other threads:[~2020-08-13 17:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 19:01 [Patch 0/5] rs6000, 128-bit Binary Integer Operations Carl Love
2020-08-11 19:22 ` [Patch 1/5] rs6000, Add 128-bit sign extension support Carl Love
2020-08-13 17:36 ` Segher Boessenkool [this message]
2020-08-13 18:09 ` Carl Love
2020-08-13 18:29 ` Segher Boessenkool
2020-08-13 22:11 ` [EXTERNAL] " will schmidt
2020-08-13 22:55 ` Segher Boessenkool
2020-08-13 23:53 ` [EXTERNAL] " will schmidt
2020-08-18 21:50 ` Segher Boessenkool
2020-08-11 19:22 ` [Patch 2/5] rs6000, 128-bit multiply, divide, modulo, shift, compare Carl Love
2020-08-13 23:46 ` will schmidt
2020-08-20 1:06 ` Segher Boessenkool
2020-08-11 19:22 ` [Patch 3/5] rs6000, Add TI to TD (128-bit DFP) and TD to TI support Carl Love
2020-08-14 17:13 ` will schmidt
2020-08-20 1:29 ` Segher Boessenkool
2020-08-26 18:23 ` Carl Love
2020-09-10 17:36 ` Segher Boessenkool
2020-08-11 19:23 ` [Patch 4/5] rs6000, Test 128-bit shifts for just the int128 type Carl Love
2020-08-14 17:35 ` will schmidt
2020-08-20 21:50 ` Segher Boessenkool
2020-08-26 20:27 ` Carl Love
2020-09-10 17:52 ` Segher Boessenkool
2020-08-11 19:23 ` [Patch 5/5] rs6000, Conversions between 128-bit integer and floating point values Carl Love
2020-08-14 18:50 ` will schmidt
2020-08-20 22:36 ` Segher Boessenkool
2020-09-19 0:25 ` will schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813173605.GG6753@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=cel@ibm.com \
--cc=cel@us.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=will_schmidt@vnet.ibm.com \
--cc=wschmidt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).