From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id C68C4386EC4B for ; Wed, 19 Aug 2020 09:47:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C68C4386EC4B Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-574-FHiRZTOEMJOHmaAhL7L0yg-1; Wed, 19 Aug 2020 05:47:07 -0400 X-MC-Unique: FHiRZTOEMJOHmaAhL7L0yg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 029BE88EF1F; Wed, 19 Aug 2020 09:47:06 +0000 (UTC) Received: from localhost (unknown [10.33.36.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id 920217BE8F; Wed, 19 Aug 2020 09:47:05 +0000 (UTC) Date: Wed, 19 Aug 2020 10:47:04 +0100 From: Jonathan Wakely To: Patrick Palka Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH] libstdc++: Implement integer-class types as defined in [iterator.concept.winc] Message-ID: <20200819094704.GH3400@redhat.com> References: <20200224201623.765972-1-ppalka@redhat.com> <32671b23-e1ef-3fb5-34f1-12df80e23068@idea> MIME-Version: 1.0 In-Reply-To: <32671b23-e1ef-3fb5-34f1-12df80e23068@idea> X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Aug 2020 09:47:23 -0000 On 11/08/20 11:38 -0400, Patrick Palka via Libstdc++ wrote: >Subject: [PATCH] libstdc++: integer-class types as per [iterator.concept.winc] > >This implements signed and unsigned integer-class types, whose width is >one bit larger than the widest supported signed and unsigned integral >type respectively. In our case this is either __int128 and unsigned >__int128, or long long and unsigned long long. > >Internally, the two integer-class types are represented as a largest >supported unsigned integral type plus one extra bit. The signed >integer-class type is represented in two's complement form with the >extra bit acting as the sign bit. > >libstdc++-v3/ChangeLog: > > * include/Makefile.am (bits_headers): Add new header > . > * include/Makefile.in: Regenerate. > * include/bits/iterator_concepts.h > (ranges::__detail::__max_diff_type): Remove definition, replace > with forward declaration of class __max_diff_type. > (__detail::__max_size_type): Remove definition, replace with > forward declaration of class __max_size_type. > (__detail::__is_unsigned_int128, __is_signed_int128, > __is_int128): New concepts. According to GNU changelog conventions you should close the parens at the end of the first line and reopen them on the next i.e. (__detail::__is_unsigned_int128, __is_signed_int128) (__is_int128): New concepts. See the paragraph beginning "Break long lists of function names" at https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html#Style-of-Change-Logs Apart from that, this looks great. Please push, thanks!