From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by sourceware.org (Postfix) with ESMTPS id 25791385DC1A; Thu, 20 Aug 2020 16:11:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 25791385DC1A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vehre@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1597939849; bh=rBD/+P15pQVlr0qP3ZGGWKluKHZcxyPugqDAmN+hkkY=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:In-Reply-To:References; b=G0rQ2gzTjzY/2AJ7/W3rIuBB4JdhxDRFidtLNFeM66pJW97ggc9Sy/FEv3W5b+DyA /Gywbr5An9BVJkbHjQql2VU7Y8yLsAOYlQY0Vbgdhf5t3wE0Y/nlGwGvbEZdhrqdQz SLwM9SUzalldOKhn6oC8lBV/qev6tJ5RL3XqZcnc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from vepi2 ([5.146.195.132]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N3siA-1kqgZc49aa-00zngk; Thu, 20 Aug 2020 18:10:49 +0200 Date: Thu, 20 Aug 2020 18:10:47 +0200 From: Andre Vehreschild To: Tobias Burnus Cc: Jakub Jelinek , Tobias Burnus , gcc-patches , fortran Subject: Re: [Patch] Fortran: Add 'device_type' clause to OpenMP's declare target Message-ID: <20200820181047.365be629@vepi2> In-Reply-To: <82b801e4-e5dc-1ba7-6fb3-da680f345fd8@codesourcery.com> References: <20200818193349.09639c4a@vepi2> <78b99997-f3dd-1f73-625e-818868e53244@net-b.de> <82b801e4-e5dc-1ba7-6fb3-da680f345fd8@codesourcery.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:9ALiXzdqyD/ZRPx6Yq82XukcWc+dVb3rso7FxNo0HSAq0KmaRGl UpNEXPPHX9qzL8ZK8wzCLwlqF+JBWAax+jmGJW+fa6QncssezmnbwcAnTVOE9SRvf4RYxr0 2Qn+39vKJ2j3uhpoM1WnPlRiFRZHaR0JUL0dbF5FqkkUgzXzA0xJrmlbjbfpoRIn4o3I1V2 3xfriJINvc3qz1Jhv50sQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:ZZZ0zNFbNlU=:xiK10De9yfkSy/pJ1lMo09 /pmPA7KCRZl7OVMN8N63T9sQJr8hfNLHLfc9oh516BwH8NpyVRUaoyGIjSghKBH3KvBVai48l VfappWIQ5Rs94LG962lZG5uPUsZHLRAIA35OLD5rXkJPuc9NKF7AXuf5lgZhee/5quleeE+5j 8gbekRiNGUadkc0bb6XkRmfa3oevJLFv4b+bDi7x6cAbYPBJgDabyOEW8E/y/SH6h7kQ8hP6r J42khTTUaW+dUvZUcnzUh6N6Aa4qv7+6A0oT4xv/D3Fq5ZXg6U40o38ffqELj/FzI40Q3azf4 PwxFKMV5u6n9baJCj+rLu2f7f7jSJpnNHutALXA37dCAcvtrDDoa+79ZulmiZ7vgeIK9HLSaW i8QZ6TBhptHlVEzMJ0BUFCL9N5JX+wDheZeX/w5RDbZwBZDwi/FnAiHEab6ZWG8JM6EJ/HmuV +s/rO7SL3tLIm+KDqz7D97FGbkLxzLQxrFxL0xXUnl7M4jH+28hBON5ivC2fLx35NWcFAsj0G K6uZZA29qg+2xO8oEDpEkLFirK3XA0nxLP87e0tuXsv8uo7HMpfBlCILF4hFNCRsaC8F6aNLt itQM0yYXCjmNf6oyG+opO/HZJMmuPeqGHgsfJKVVRy1dRLxuSd1v85Fa19qu42zaL7Zb2EDbI NQ+1m/Eb7psn23hIm8+orpcbgzqaj4reSW/Nzw+Pwbv6aCEaRIn1mc/jbA7eOEh7D31dDGY9M zSOiRbN6ckfLe4rtNgHEoPJdQJ4IX8TnyHh5DZNDbvOl7qb88f+6FA+fOxsozsjlTkwJSii/b ufSDGXyJkTVgEw5Q8viqkx37Mvk9TC0wWiGvNbnA0/lWZwWjGCZ7ENQejFBwqHWCY2ymYAMtR bdbclUTa6PKLG6MIAc381DQRgcGa9pPNDanA+5UIKkwU7+vnazOcxC0v8yC6dbRaQiMd7hcnH ScGgLSQVfrAxlcTVmw/Lgi8dmb2MBrZv+RtFN3Lin0Y9ivs5gMFlfcAcXCqzYmr2XnMCzjRrV 5NI67umGBVXW1AhFxvQ7a+nBlTQRypJ3cBY/LO6ihfchLV7ycKk8zLI6lph+35/U4b+TsLaeY erazyf4ZGt8D293x6GW/0stASdeSSsBA0bNLdG2FG44K7wFgzZKg3EXVYjG/K/1fhwuGKFrRg bjtg1lwEOEbKCP+36i9r8fzC6DA0oRJvZ4jJlR0gHWETsFxTM4R/gw9Hr+lMqn27eMFhMOu2D QguHKlAVCq8b4Hhrl X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Aug 2020 16:11:08 -0000 Hi Tobias, to me this looks OK now. Regards, Andre On Thu, 20 Aug 2020 11:51:50 +0200 Tobias Burnus wrote: > Updated patch =E2=80=93 taking Andre's suggestions into account + > extending the testcase, which now catches the previous (NO)HOST > module issue. >=20 > OK? >=20 > Tobias >=20 > On 8/19/20 2:51 PM, Tobias Burnus wrote: > > Am 18.08.20 um 19:33 schrieb Andre Vehreschild: =20 > >> + case OMP_DEVICE_TYPE_HOST: > >> + MIO_NAME (ab_attribute) (AB_OMP_DEVICE_TYPE_NOHOST, attr_bits); > >> Why also NOHOST here? =20 > > Copy and paste error. =20 > ... > >> + tree clauses =3D NULL_TREE; > >> Would you mind using "omp_clauses" or the like here? =20 > Done now. > ----------------- > Mentor Graphics (Deutschland) GmbH, Arnulfstra=C3=9Fe 201, 80634 M=C3=BCn= chen / Germany > Registergericht M=C3=BCnchen HRB 106955, Gesch=C3=A4ftsf=C3=BChrer: Thoma= s Heurung, > Alexander Walter --=20 Andre Vehreschild * Email: vehre ad gmx dot de=20