public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Giuliano Belinassi <giuliano.belinassi@usp.br>
To: Josh Triplett <josh@joshtriplett.org>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 0/6] Parallelize Intra-Procedural Optimizations using the LTO Engine.
Date: Sat, 22 Aug 2020 18:04:48 -0300	[thread overview]
Message-ID: <20200822210448.2qelp2qrswmyebkp@smtp.gmail.com> (raw)
In-Reply-To: <20200821210858.GA78556@localhost>

Hi, Josh

On 08/21, Josh Triplett wrote:
> On Thu, Aug 20, 2020 at 07:00:13PM -0300, Giuliano Belinassi wrote:
> > This patch series add a new flag "-fparallel-jobs=" to control if the
> > compiler should try to compile the current file in parallel.
> [...]
> > Bootstrapped and Regtested on Linux x86_64.
> > 
> > Giuliano Belinassi (6):
> >   Modify gcc driver for parallel compilation
> >   Implement a new partitioner for parallel compilation
> >   Implement fork-based parallelism engine
> >   Add `+' for Jobserver Integration
> >   Add invoke documentation
> >   New tests for parallel compilation feature
> 
> Very nice!

Thank you for your interest in this :)

> 
> I'm interested in testing this on a highly parallel system. What
> baseline do these patches apply to?  They don't seem to apply to GCC
> trunk.

Hummm, this was supposed to work on trunk out of the box. However,
there is a high probability that I messed up something while rebasing.
I will post a version 2 of it when I get more comments and when I fix
the Makefile issue that Joseph pointed out in other e-mail.

If you want to test it on a high parallel system, I think it will be
cool to see how it behaves also when --param=promote-statics=1, as it
increases parallelism opportunity. :)

> 
> Also, I tried to bootstrap the current tip of the devel/autopar_devel
> branch, but ended up with compiler segfaults that all look like this:
> ../../gcc/zlib/compress.c:86:1: internal compiler error: Segmentation fault
>    86 | }
>       | ^

Well, there was once a bug in this branch when compiling with -flto that
caused the assembler output file not to be properly initialized early
enough, resulting in LTO LGEN stage writing into a invalid FILE pointer.
I fixed this during rebasing but I forgot to push to the autopar_devel
branch. In any case, I just pushed the recent changes to autopar_devel
which fix this issue.

In any case, -fparallel-jobs= should NOT be used together with -flto.
Although I used part of the LTO engine for development of this feature,
they are meant for distinct things. I guess I should give a warning
about that in next version :)

Also, I just tested bootstrap with

../gcc/configure --disable-multilib --enable-languages=c,c++

on x86_64 linux and it is working.

Thank you,
Giuliano.

  reply	other threads:[~2020-08-22 21:04 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-20 22:00 Giuliano Belinassi
2020-08-20 22:00 ` [PATCH 1/6] Modify gcc driver for parallel compilation Giuliano Belinassi
2020-08-24 13:17   ` Richard Biener
2020-08-24 18:06     ` Giuliano Belinassi
2020-08-25  6:53       ` Richard Biener
2020-08-20 22:00 ` [PATCH 2/6] Implement a new partitioner " Giuliano Belinassi
2020-08-27 15:18   ` Jan Hubicka
2020-08-27 21:42     ` Giuliano Belinassi
2020-08-31  9:25   ` Richard Biener
2020-08-20 22:00 ` [PATCH 3/6] Implement fork-based parallelism engine Giuliano Belinassi
2020-08-27 15:25   ` Jan Hubicka
2020-08-27 15:37   ` Jan Hubicka
2020-08-27 18:27     ` Giuliano Belinassi
2020-08-29 11:41       ` Jan Hubicka
2020-08-31  9:33       ` Richard Biener
2020-08-20 22:00 ` [PATCH 4/6] Add `+' for Jobserver Integration Giuliano Belinassi
2020-08-20 22:33   ` Joseph Myers
2020-08-24 13:19     ` Richard Biener
2020-08-27 15:38     ` Jan Hubicka
2020-08-20 22:00 ` [PATCH 5/6] Add invoke documentation Giuliano Belinassi
2020-08-20 22:00 ` [PATCH 6/6] New tests for parallel compilation feature Giuliano Belinassi
2020-08-21 21:08 ` [PATCH 0/6] Parallelize Intra-Procedural Optimizations using the LTO Engine Josh Triplett
2020-08-22 21:04   ` Giuliano Belinassi [this message]
2020-08-24 16:44     ` Josh Triplett
2020-08-24 18:38       ` Giuliano Belinassi
2020-08-25  7:03         ` Richard Biener
2020-08-24 12:50 ` Richard Biener
2020-08-24 15:13   ` Giuliano Belinassi
2020-08-29 11:31     ` Jan Hubicka
2020-08-31  8:15       ` Richard Biener
2020-08-31 11:44         ` Jan Hubicka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200822210448.2qelp2qrswmyebkp@smtp.gmail.com \
    --to=giuliano.belinassi@usp.br \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=josh@joshtriplett.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).