From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 81180386EC47 for ; Wed, 26 Aug 2020 20:56:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 81180386EC47 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-470-7pZZQiumNp6xI7-WLvPiMw-1; Wed, 26 Aug 2020 16:56:55 -0400 X-MC-Unique: 7pZZQiumNp6xI7-WLvPiMw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5664A1005E5C; Wed, 26 Aug 2020 20:56:54 +0000 (UTC) Received: from localhost (unknown [10.33.36.61]) by smtp.corp.redhat.com (Postfix) with ESMTP id E97FF5C1C2; Wed, 26 Aug 2020 20:56:53 +0000 (UTC) Date: Wed, 26 Aug 2020 21:56:53 +0100 From: Jonathan Wakely To: Patrick Palka Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Subject: Re: [PATCH 1/3] libstdc++: Implement P1994R1 changes to ranges::elements_view Message-ID: <20200826205653.GO3400@redhat.com> References: <20200826204454.1375362-1-ppalka@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200826204454.1375362-1-ppalka@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Aug 2020 20:57:00 -0000 On 26/08/20 16:44 -0400, Patrick Palka via Libstdc++ wrote: >The example from the paper doesn't compile without the proposed >resolution for LWG 3406, so we'll add a testcase for this once the >proposed resolution is in. > >libstdc++-v3/ChangeLog: > > P1994R1: elements_view needs its own sentinel. > * include/std/ranges (elements_view::end): Replace these two > overloads with four new overloads. > (elements_view::_Iterator::operator==): Remove. > (elements_view::_Iterator::operator-): Likewise. > (elements_view::_Sentinel): Define. OK, thanks.