From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id E4975386F028 for ; Wed, 26 Aug 2020 20:57:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E4975386F028 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-563-PlnQrRX-NqSBz2mBCdUUEA-1; Wed, 26 Aug 2020 16:57:15 -0400 X-MC-Unique: PlnQrRX-NqSBz2mBCdUUEA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E1DD0189E60F; Wed, 26 Aug 2020 20:57:14 +0000 (UTC) Received: from localhost (unknown [10.33.36.61]) by smtp.corp.redhat.com (Postfix) with ESMTP id 94AA85C1C2; Wed, 26 Aug 2020 20:57:14 +0000 (UTC) Date: Wed, 26 Aug 2020 21:57:13 +0100 From: Jonathan Wakely To: Patrick Palka Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Subject: Re: [PATCH 2/3] libstdc++: elements_view's sentinel and iterator not comparable [LWG 3406] Message-ID: <20200826205713.GP3400@redhat.com> References: <20200826204454.1375362-1-ppalka@redhat.com> <20200826204454.1375362-2-ppalka@redhat.com> MIME-Version: 1.0 In-Reply-To: <20200826204454.1375362-2-ppalka@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Aug 2020 20:57:20 -0000 On 26/08/20 16:44 -0400, Patrick Palka via Libstdc++ wrote: >This implements the proposed resolution for LWG 3406 and adds a testcase >for the example from P1994R1. > >libstdc++-v3/ChangeLog: > > LWG 3406 > * include/std/ranges (elements_view::begin): Adjust constraints. > (elements_view::end): Likewise. > (elements_view::_Sentinel::operator==): Templatize to take both > _Iterator and _Iterator. > (elements_view::_Sentinel::operator-): Likewise. > * testsuite/std/ranges/adaptors/elements.cc: Add testcase for > the example from P1994R1. > * testsuite/std/range/adaptors/lwg3406.cc: New test. OK, thanks.