From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id 515A43857C6D for ; Fri, 11 Sep 2020 15:31:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 515A43857C6D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=segher@kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 08BFTaUP011963; Fri, 11 Sep 2020 10:29:36 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 08BFTWE8011958; Fri, 11 Sep 2020 10:29:32 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Fri, 11 Sep 2020 10:29:32 -0500 From: Segher Boessenkool To: Jojo R Cc: richard.sandiford@arm.com, ro@CeBiTec.Uni-Bielefeld.DE, richard.guenther@gmail.com, joseph@codesourcery.com, gcc-patches@gcc.gnu.org, yunhai.syh@alibaba-inc.com Subject: Re: [PATCH v6] genemit.c (main): split insn-emit.c for compiling parallelly Message-ID: <20200911152932.GB28786@gate.crashing.org> References: <20200911072617.48558-1-jiejie_rong@c-sky.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200911072617.48558-1-jiejie_rong@c-sky.com> User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, TXREP, T_SPF_HELO_PERMERROR, T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Sep 2020 15:31:06 -0000 Hi! On Fri, Sep 11, 2020 at 03:26:17PM +0800, Jojo R wrote: > +#define printf_include() do { \ Don't use macros please, use a function? And maybe do this in a separate patch, for ease of review. That should be ack'ed pretty much immediately, after which it is out of the way, and we do not have to see it again. > while (read_md_rtx (&info)) > - switch (GET_CODE (info.def)) Factor this body to a separate function, too? Again, as earlier patch. As it is, it is impossible to see if you changed anything here. I suspect all this patch really does is pretty trivial, but it is hard to tell. Segher