From: Alan Modra <amodra@gmail.com>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: gcc-patches@sourceware.org, Alan Modra <amodra@gmail.com>
Subject: [RS6000] rs6000_rtx_costs comment
Date: Tue, 15 Sep 2020 10:49:42 +0930 [thread overview]
Message-ID: <20200915011946.3395-5-amodra@gmail.com> (raw)
In-Reply-To: <20200915011946.3395-1-amodra@gmail.com>
Prior patches in this series were small bug fixes. This lays out the
ground rules for following patches.
* config/rs6000/rs6000.c (rs6000_rtx_costs): Expand comment.
diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs6000.c
index 523d029800a..5b3c0ee0e8c 100644
--- a/gcc/config/rs6000/rs6000.c
+++ b/gcc/config/rs6000/rs6000.c
@@ -21133,7 +21133,45 @@ rs6000_cannot_copy_insn_p (rtx_insn *insn)
/* Compute a (partial) cost for rtx X. Return true if the complete
cost has been computed, and false if subexpressions should be
- scanned. In either case, *TOTAL contains the cost result. */
+ scanned. In either case, *TOTAL contains the cost result.
+
+ 1) Calls from places like optabs.c:avoid_expensive_constant will
+ come here with OUTER_CODE set to an operation such as AND with X
+ being a CONST_INT or other CONSTANT_P type. This will be compared
+ against set_src_cost, where we'll come here with OUTER_CODE as SET
+ and X the same constant.
+
+ 2) Calls from places like combine:distribute_and_simplify_rtx are
+ asking whether a possibly quite complex SET_SRC can be implemented
+ more cheaply than some other logically equivalent SET_SRC.
+
+ 3) Calls from places like default_noce_conversion_profitable_p will
+ come here via seq_cost and pass the pattern of a SET insn in X.
+ Presuming the insn is valid and set_dest a reg, rs6000_rtx_costs
+ will next see the SET_SRC. The overall cost should be comparable
+ to rs6000_insn_cost since the code is comparing one insn sequence
+ (some of which may be costed by insn_cost) against another insn
+ sequence.
+
+ 4) Calls from places like cprop.c:try_replace_reg will come here
+ with OUTER_CODE as INSN, and X either a valid pattern of a SET or
+ one where some registers have been replaced with constants. The
+ replacements may make the SET invalid, for example if
+ (set (reg1) (and (reg2) (const_int 0xfff)))
+ replaces reg2 as
+ (set (reg1) (and (symbol_ref) (const_int 0xfff)))
+ then the replacement can't be implemented in one instruction and
+ really the cost should be higher by one instruction. However,
+ the cost for invalid insns doesn't matter much except that a
+ higher cost may lead to their rejection earlier.
+
+ 5) fwprop.c:should_replace_address puts yet another wrinkle on this
+ function, where we prefer an address calculation that is more
+ complex yet has the same address_cost. In this case "more
+ complex" is determined by having a higher set_src_cost. So for
+ example, if we want a plain (reg) address to be replaced with
+ (plus (reg) (const)) when possible then PLUS needs to cost more
+ than zero here. */
static bool
rs6000_rtx_costs (rtx x, machine_mode mode, int outer_code,
next prev parent reply other threads:[~2020-09-15 1:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-15 1:19 [RS6000] rtx_costs Alan Modra
2020-09-15 1:19 ` [RS6000] Count rldimi constant insns Alan Modra
2020-09-15 22:29 ` Segher Boessenkool
2020-09-15 1:19 ` [RS6000] rs6000_rtx_costs for PLUS/MINUS constant Alan Modra
2020-09-15 22:31 ` Segher Boessenkool
2020-09-15 1:19 ` [RS6000] rs6000_rtx_costs for AND Alan Modra
2020-09-15 18:15 ` will schmidt
2020-09-16 7:24 ` Alan Modra
2020-09-15 1:19 ` Alan Modra [this message]
2020-09-16 23:21 ` [RS6000] rs6000_rtx_costs comment Segher Boessenkool
2020-09-15 1:19 ` [RS6000] rs6000_rtx_costs multi-insn constants Alan Modra
2020-09-16 23:28 ` Segher Boessenkool
2020-09-15 1:19 ` [RS6000] rs6000_rtx_costs cost IOR Alan Modra
2020-09-17 0:02 ` Segher Boessenkool
2020-09-17 3:42 ` Alan Modra
2020-09-21 15:49 ` Segher Boessenkool
2020-09-21 23:54 ` Alan Modra
2020-09-15 1:19 ` [RS6000] rs6000_rtx_costs reduce cost for SETs Alan Modra
2020-09-17 17:51 ` Segher Boessenkool
2020-09-18 3:38 ` Alan Modra
2020-09-18 18:13 ` Segher Boessenkool
2020-09-21 7:07 ` Alan Modra
2020-09-15 1:19 ` [RS6000] rotate and mask constants Alan Modra
2020-09-15 7:16 ` Alan Modra
2020-09-21 15:56 ` Segher Boessenkool
2020-09-15 18:15 ` [RS6000] rtx_costs will schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915011946.3395-5-amodra@gmail.com \
--to=amodra@gmail.com \
--cc=gcc-patches@sourceware.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).