* [PATCH] Compile gcc.target/i386/pr78904-4a.c with -mtune=generic
@ 2020-09-15 14:32 H.J. Lu
2020-09-17 4:12 ` Jeff Law
0 siblings, 1 reply; 2+ messages in thread
From: H.J. Lu @ 2020-09-15 14:32 UTC (permalink / raw)
To: gcc-patches
commit e95395926a84a2406faefe0995295d199d595440
Author: Uros Bizjak <ubizjak@gmail.com>
Date: Thu Jun 18 20:12:48 2020 +0200
i386: Fix mode of ZERO_EXTRACT RTXes, remove ext_register_operand predicate.
caused
FAIL: gcc.target/i386/pr78904-4a.c scan-assembler [ \t]movb[\t ]+%.h, t
when compiled with --target_board='unix{-m32\ -march=cascadelake}'. With
-mtune=generic:
movzwl 4(%esp), %edx
movl 8(%esp), %eax
movb %dh, t(%eax)
ret
With -mtune=cascadelake:
movzbl 5(%esp), %edx
movl 8(%esp), %eax
movb %dl, t(%eax)
ret
Add -mtune=generic for --target_board='unix{-m32\ -march=cascadelake}'.
---
gcc/testsuite/gcc.target/i386/pr78904-4a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/testsuite/gcc.target/i386/pr78904-4a.c b/gcc/testsuite/gcc.target/i386/pr78904-4a.c
index 5e6159a7648..6a100c01667 100644
--- a/gcc/testsuite/gcc.target/i386/pr78904-4a.c
+++ b/gcc/testsuite/gcc.target/i386/pr78904-4a.c
@@ -1,7 +1,7 @@
/* PR target/78904 */
/* { dg-do compile } */
/* { dg-require-effective-target nonpic } */
-/* { dg-options "-O2 -masm=att" } */
+/* { dg-options "-O2 -masm=att -mtune=generic" } */
typedef __SIZE_TYPE__ size_t;
--
2.26.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Compile gcc.target/i386/pr78904-4a.c with -mtune=generic
2020-09-15 14:32 [PATCH] Compile gcc.target/i386/pr78904-4a.c with -mtune=generic H.J. Lu
@ 2020-09-17 4:12 ` Jeff Law
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Law @ 2020-09-17 4:12 UTC (permalink / raw)
To: H.J. Lu, gcc-patches
[-- Attachment #1: Type: text/plain, Size: 807 bytes --]
On 9/15/20 8:32 AM, H.J. Lu via Gcc-patches wrote:
> commit e95395926a84a2406faefe0995295d199d595440
> Author: Uros Bizjak <ubizjak@gmail.com>
> Date: Thu Jun 18 20:12:48 2020 +0200
>
> i386: Fix mode of ZERO_EXTRACT RTXes, remove ext_register_operand predicate.
>
> caused
>
> FAIL: gcc.target/i386/pr78904-4a.c scan-assembler [ \t]movb[\t ]+%.h, t
>
> when compiled with --target_board='unix{-m32\ -march=cascadelake}'. With
> -mtune=generic:
>
> movzwl 4(%esp), %edx
> movl 8(%esp), %eax
> movb %dh, t(%eax)
> ret
>
> With -mtune=cascadelake:
>
> movzbl 5(%esp), %edx
> movl 8(%esp), %eax
> movb %dl, t(%eax)
> ret
>
> Add -mtune=generic for --target_board='unix{-m32\ -march=cascadelake}'.
OK with an appropriate ChangeLog entry on the commit.
jeff
[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 1763 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-17 4:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-15 14:32 [PATCH] Compile gcc.target/i386/pr78904-4a.c with -mtune=generic H.J. Lu
2020-09-17 4:12 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).