From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 40A353857C69 for ; Wed, 16 Sep 2020 08:17:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 40A353857C69 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-19-kLs6IkHaNaeeuyJsWdjJzQ-1; Wed, 16 Sep 2020 04:17:23 -0400 X-MC-Unique: kLs6IkHaNaeeuyJsWdjJzQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B3E6F8064B1; Wed, 16 Sep 2020 08:17:22 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-113-252.ams2.redhat.com [10.36.113.252]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 34D2E1002D46; Wed, 16 Sep 2020 08:17:22 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id 08G8HIpw005591; Wed, 16 Sep 2020 10:17:19 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id 08G8HHX4005590; Wed, 16 Sep 2020 10:17:17 +0200 Date: Wed, 16 Sep 2020 10:17:17 +0200 From: Jakub Jelinek To: Vaseeharan Vinayagamoorthy Cc: Richard Earnshaw , Kyrylo Tkachov , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH] arm: Fix up gcc.target/arm/lto/pr96939_* FAIL Message-ID: <20200916081717.GU21814@tucnak> Reply-To: Jakub Jelinek References: <20200913083857.GH21814@tucnak> <9E93546E-8FB0-4AA6-A273-216CD168F741@arm.com> MIME-Version: 1.0 In-Reply-To: <9E93546E-8FB0-4AA6-A273-216CD168F741@arm.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Sep 2020 08:17:28 -0000 On Tue, Sep 15, 2020 at 03:32:40PM +0000, Vaseeharan Vinayagamoorthy wrote: > I am seeing this unused parameter 'opts' error when building for this configuration: > Build: arm-none-linux-gnueabihf > Host: arm-none-linux-gnueabihf > Target: arm-none-linux-gnueabihf > > In function 'void arm_option_restore(gcc_options*, gcc_options*, cl_target_option*)': > /src/gcc/gcc/config/arm/arm.c:3042:41: error: unused parameter 'opts' [-Werror=unused-parameter] > 3042 | arm_option_restore (struct gcc_options *opts, struct gcc_options *opts_set, > | ~~~~~~~~~~~~~~~~~~~~^~~~ Oops, sorry, don't know how this got through, fixed as obvious with the patch below: 2020-09-16 Jakub Jelinek * config/arm/arm.c (arm_option_restore): Comment out opts argument name to avoid unused parameter warnings. --- gcc/config/arm/arm.c +++ gcc/config/arm/arm.c @@ -3039,8 +3039,8 @@ arm_override_options_after_change (void) /* Implement TARGET_OPTION_RESTORE. */ static void -arm_option_restore (struct gcc_options *opts, struct gcc_options *opts_set, - struct cl_target_option *ptr) +arm_option_restore (struct gcc_options */* opts */, + struct gcc_options *opts_set, struct cl_target_option *ptr) { arm_configure_build_target (&arm_active_target, ptr, opts_set, false); } Jakub