From: Jakub Jelinek <jakub@redhat.com>
To: Tobias Burnus <tobias@codesourcery.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, fortran <fortran@gcc.gnu.org>
Subject: Re: [Patch] Fortran: OpenMP - fix simd with (last)private (PR97061
Date: Wed, 16 Sep 2020 16:11:05 +0200 [thread overview]
Message-ID: <20200916141105.GA21814@tucnak> (raw)
In-Reply-To: <faa6b2f5-319f-b1a6-5326-2be309276394@codesourcery.com>
On Wed, Sep 16, 2020 at 04:08:16PM +0200, Tobias Burnus wrote:
> Using linear (added by the compiler) + explicit lastprivate gives an error.
>
> To quote Jakub from the PR:
> "If it is the FE that adds the linear clause, then it
> shouldn't when there is explicit lastprivate clause.
> This is a new thing in OpenMP 5.0, in 4.5 it was invalid to
> make the iterate anything but linear in this case, now
> it can be made private or lastprivate."
>
> Actually, the check which permitted this was committed
> early during GCC 11 development, but the some updates of
> trans-openmp.c were missing.
>
> OK?
Yes, thanks.
> Fortran: OpenMP - fix simd with (last)private (PR97061)
>
> gcc/fortran/ChangeLog:
>
> PR fortran/97061
> * trans-openmp.c (gfc_trans_omp_do): Handle simd with (last)private.
>
> gcc/testsuite/ChangeLog:
>
> PR fortran/97061
> * gfortran.dg/gomp/openmp-simd-6.f90: New test.
Jakub
prev parent reply other threads:[~2020-09-16 14:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 14:08 Tobias Burnus
2020-09-16 14:11 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916141105.GA21814@tucnak \
--to=jakub@redhat.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).