From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 7B4F0398C810 for ; Thu, 17 Sep 2020 16:46:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7B4F0398C810 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-331-7euAGXDMPIOWdM4tijV3HQ-1; Thu, 17 Sep 2020 12:46:37 -0400 X-MC-Unique: 7euAGXDMPIOWdM4tijV3HQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9294F188C130; Thu, 17 Sep 2020 16:46:00 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-113-252.ams2.redhat.com [10.36.113.252]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7EE3E7A469; Thu, 17 Sep 2020 16:45:58 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id 08HGjs8B031575; Thu, 17 Sep 2020 18:45:55 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id 08HGjrb3031574; Thu, 17 Sep 2020 18:45:53 +0200 Date: Thu, 17 Sep 2020 18:45:53 +0200 From: Jakub Jelinek To: Mark Wielaard Cc: Jason Merrill , gcc-patches@gcc.gnu.org Subject: Re: [PATCH 3/5] Add DWARF5 variants of assembly scan tests that use DW_FORM_implicit_const Message-ID: <20200917164553.GD26561@tucnak> Reply-To: Jakub Jelinek References: <20200824125658.22526-1-mark@klomp.org> <20200824125658.22526-4-mark@klomp.org> <20200824174427.GO2363@tucnak> <20200824202607.GC3062@wildebeest.org> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Sep 2020 16:46:47 -0000 On Thu, Sep 17, 2020 at 06:03:28PM +0200, Mark Wielaard wrote: > On Mon, 2020-08-24 at 22:26 +0200, Mark Wielaard wrote: > > On Mon, Aug 24, 2020 at 07:44:27PM +0200, Jakub Jelinek wrote: > > > On Mon, Aug 24, 2020 at 02:56:56PM +0200, Mark Wielaard wrote: > > > > Some DWARF tests scan the assembly output looking for constant values. > > > > When using DWARF5 those constants might use DW_FORM_implicit_const, > > > > which are output (in the comments) after the attribute instead of > > > > before. To make sure these tests work introduce a -gdwarf-5 variant > > > > of these tests and explicitly use -gdwarf-2 for the original. > > > > > > I just wonder if we want to use -gdwarf-2 rather than -gdwarf-4 in the > > > original, -gdwarf-5 has been the default for a couple of years and thus > > > that is what those testshave been compiled with. > > > > I used -gdwarf-2 because I thought that was still the default for some > > arches/platforms. And they pass with -gdwarf-2. > > > > > Also not sure about the -dwarf5 suffixes, couldn't we say just use > > > pr41445-{7,8}.c, inline-var-2.C or inline3.c (or whatever next number > > > with the same prefix is still unused)? > > > > Sure, if that is a better naming scheme I'll rename them. > > Here is the adjusted patch. > > gcc/testsuite/ChangeLog: > > * gcc.dg/debug/dwarf2/inline2.c: Add -gdwarf-2. > * g++.dg/debug/dwarf2/inline-var-1.C: Likewise. > * gcc/testsuite/gcc.dg/debug/dwarf2/pr41445-5.c: Likewise. > * gcc/testsuite/gcc.dg/debug/dwarf2/pr41445-6.c: Likewise. > * gcc.dg/debug/dwarf2/inline6.c: New variant with -gdwarf-5. > * g++.dg/debug/dwarf2/inline-var-3.C: Likewise. > * gcc/testsuite/gcc.dg/debug/dwarf2/pr41445-7.c: Likewise. > * gcc/testsuite/gcc.dg/debug/dwarf2/pr41445-8.c: Likewise. > > OK to commit? Ok, thanks. Jakub