From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id F1A3D386EC2F for ; Tue, 22 Sep 2020 08:48:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F1A3D386EC2F Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-194-m7ObEbsqMK2sGHa1DlDvmw-1; Tue, 22 Sep 2020 04:48:03 -0400 X-MC-Unique: m7ObEbsqMK2sGHa1DlDvmw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D17F2802B74; Tue, 22 Sep 2020 08:48:02 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-112-37.ams2.redhat.com [10.36.112.37]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5FEEE55783; Tue, 22 Sep 2020 08:48:02 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id 08M8lslj019044; Tue, 22 Sep 2020 10:47:54 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id 08M8lr1k019043; Tue, 22 Sep 2020 10:47:53 +0200 Date: Tue, 22 Sep 2020 10:47:53 +0200 From: Jakub Jelinek To: Jan Hubicka , gcc-patches@gcc.gnu.org Subject: Re: [committed] ipa: Fix up ipa modref option help texts Message-ID: <20200922084753.GY2176@tucnak> Reply-To: Jakub Jelinek References: <157394261677.27454.2367573047582814412@a285.localdomain> <20200919223255.GA69342@kam.mff.cuni.cz> <20200922081346.GX2176@tucnak> MIME-Version: 1.0 In-Reply-To: <20200922081346.GX2176@tucnak> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Sep 2020 08:48:07 -0000 On Tue, Sep 22, 2020 at 10:13:46AM +0200, Jakub Jelinek via Gcc-patches wrote: > --- gcc/params.opt.jj 2020-09-21 11:15:53.816516949 +0200 > +++ gcc/params.opt 2020-09-22 09:59:37.121115589 +0200 > @@ -882,7 +882,7 @@ Maximum number of refs stored in each mo > > -param=modref-max-tests= > Common Joined UInteger Var(param_modref_max_tests) Init(64) > -Maximum number of tests perofmed by modref query > +Maximum number of tests perofmed by modref query. And seeing the above typo led me to do some spell checking around. Here is the result, committed as obvious to trunk: 2020-09-22 Jakub Jelinek gcc/ * params.opt (--param=modref-max-tests=): Fix typo in help text: perofmed -> performed. * common.opt: Fix typo: incrmeental -> incremental. * ipa-modref.c: Fix typos: recroding -> recording, becaue -> because, analsis -> analysis. (class modref_summaries): Fix typo: betweehn -> between. (analyze_call): Fix typo: calle -> callee. (read_modref_records): Fix typo: expcted -> expected. (pass_ipa_modref::execute): Fix typo: calle -> callee. gcc/c-family/ * c.opt (Wbuiltin-declaration-mismatch): Fix typo in variable name: warn_builtin_declaraion_mismatch -> warn_builtin_declaration_mismatch. --- gcc/params.opt.jj 2020-09-22 09:59:37.121115589 +0200 +++ gcc/params.opt 2020-09-22 10:17:30.232362715 +0200 @@ -882,7 +882,7 @@ Maximum number of refs stored in each mo -param=modref-max-tests= Common Joined UInteger Var(param_modref_max_tests) Init(64) -Maximum number of tests perofmed by modref query. +Maximum number of tests performed by modref query. -param=tm-max-aggregate-size= Common Joined UInteger Var(param_tm_max_aggregate_size) Init(9) Param Optimization --- gcc/common.opt.jj 2020-09-22 10:00:00.034779245 +0200 +++ gcc/common.opt 2020-09-22 10:24:06.702542396 +0200 @@ -47,7 +47,7 @@ Variable bool in_lto_p = false ; This variable is set to non-0 only by LTO front-end. 1 indicates that -; the output produced will be used for incrmeental linking (thus weak symbols +; the output produced will be used for incremental linking (thus weak symbols ; can still be bound) and 2 indicates that the IL is going to be linked and ; and output to LTO object file. Variable --- gcc/ipa-modref.c.jj 2020-09-21 11:15:53.759517788 +0200 +++ gcc/ipa-modref.c 2020-09-22 10:32:01.298577455 +0200 @@ -35,10 +35,10 @@ along with GCC; see the file COPYING3. propagates across the callgraph and is able to handle recursion and works on whole program during link-time analysis. - LTO mode differs from the local mode by not recroding alias sets but types + LTO mode differs from the local mode by not recording alias sets but types that are translated to alias sets later. This is necessary in order stream - the information becaue the alias sets are rebuild at stream-in time and may - not correspond to ones seen during analsis. For this reason part of analysis + the information because the alias sets are rebuild at stream-in time and may + not correspond to ones seen during analysis. For this reason part of analysis is duplicated. */ #include "config.h" @@ -77,7 +77,7 @@ public: modref_summary *src_data, modref_summary *dst_data); /* This flag controls whether newly inserted functions should be analyzed - in IPA or normal mode. Functions inserted betweehn IPA analysis and + in IPA or normal mode. Functions inserted between IPA analysis and ipa-modref pass execution needs to be analyzed in IPA mode while all other insertions leads to normal analysis. */ bool ipa; @@ -413,7 +413,7 @@ analyze_call (modref_summary *cur_summar struct cgraph_node *callee_node = cgraph_node::get_create (callee); - /* We can not safely optimize based on summary of calle if it does + /* We can not safely optimize based on summary of callee if it does not always bind to current def: it is possible that memory load was optimized out earlier which may not happen in the interposed variant. */ @@ -815,7 +815,7 @@ write_modref_records (modref_records_lto /* Read a modref_tree from the input block IB using the data from DATA_IN. This assumes that the tree was encoded using write_modref_tree. Either nolto_ret or lto_ret is initialized by the tree depending whether - LTO streaming is expcted or not. */ + LTO streaming is expected or not. */ void read_modref_records (lto_input_block *ib, struct data_in *data_in, @@ -1238,7 +1238,7 @@ unsigned int pass_ipa_modref::execute (f fprintf (dump_file, " Call to %s\n", cur->dump_name ()); - /* We can not safely optimize based on summary of calle if it + /* We can not safely optimize based on summary of callee if it does not always bind to current def: it is possible that memory load was optimized out earlier which may not happen in the interposed variant. */ --- gcc/c-family/c.opt.jj 2020-09-22 09:49:22.321140717 +0200 +++ gcc/c-family/c.opt 2020-09-22 10:29:02.240204836 +0200 @@ -371,7 +371,7 @@ C ObjC C++ ObjC++ Var(warn_frame_address Warn when __builtin_frame_address or __builtin_return_address is used unsafely. Wbuiltin-declaration-mismatch -C ObjC C++ ObjC++ Var(warn_builtin_declaraion_mismatch) Init(1) Warning +C ObjC C++ ObjC++ Var(warn_builtin_declaration_mismatch) Init(1) Warning Warn when a built-in function is declared with the wrong signature. Wbuiltin-macro-redefined Jakub