public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Patrick Palka <ppalka@redhat.com>
To: gcc-patches@gcc.gnu.org
Cc: libstdc++@gcc.gnu.org, Patrick Palka <ppalka@redhat.com>
Subject: [PATCH 2/4] libstdc++: Reduce the size of a subrange with empty sentinel type
Date: Mon, 28 Sep 2020 00:48:52 -0400	[thread overview]
Message-ID: <20200928044854.46674-2-ppalka@redhat.com> (raw)
In-Reply-To: <20200928044854.46674-1-ppalka@redhat.com>

libstdc++-v3/ChangeLog:

	* include/bits/ranges_util.h (subrange::_M_end): Give it
	[[no_unique_adcress]].
	* testsuite/std/ranges/subrange/sizeof.cc: New test.
---
 libstdc++-v3/include/bits/ranges_util.h       |  2 +-
 .../testsuite/std/ranges/subrange/sizeof.cc   | 28 +++++++++++++++++++
 2 files changed, 29 insertions(+), 1 deletion(-)
 create mode 100644 libstdc++-v3/testsuite/std/ranges/subrange/sizeof.cc

diff --git a/libstdc++-v3/include/bits/ranges_util.h b/libstdc++-v3/include/bits/ranges_util.h
index 694ae796399..a98658ff5c8 100644
--- a/libstdc++-v3/include/bits/ranges_util.h
+++ b/libstdc++-v3/include/bits/ranges_util.h
@@ -208,7 +208,7 @@ namespace ranges
 	= _Kind == subrange_kind::sized && !sized_sentinel_for<_Sent, _It>;
 
       _It _M_begin = _It();
-      _Sent _M_end = _Sent();
+      [[no_unique_address]] _Sent _M_end = _Sent();
 
       template<typename, bool = _S_store_size>
 	struct _Size
diff --git a/libstdc++-v3/testsuite/std/ranges/subrange/sizeof.cc b/libstdc++-v3/testsuite/std/ranges/subrange/sizeof.cc
new file mode 100644
index 00000000000..7e95e196c6c
--- /dev/null
+++ b/libstdc++-v3/testsuite/std/ranges/subrange/sizeof.cc
@@ -0,0 +1,28 @@
+// Copyright (C) 2020 Free Software Foundation, Inc.
+//
+// This file is part of the GNU ISO C++ Library.  This library is free
+// software; you can redistribute it and/or modify it under the
+// terms of the GNU General Public License as published by the
+// Free Software Foundation; either version 3, or (at your option)
+// any later version.
+
+// This library is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+
+// You should have received a copy of the GNU General Public License along
+// with this library; see the file COPYING3.  If not see
+// <http://www.gnu.org/licenses/>.
+
+// { dg-options "-std=gnu++2a" }
+// { dg-do compile { target c++2a } }
+
+#include <iterator>
+#include <ranges>
+
+// Verify we optimize away the 'end' data member of a subrange with an empty
+// sentinel type.
+static_assert(sizeof(std::ranges::subrange<std::counted_iterator<int*>,
+					   std::default_sentinel_t>)
+	      == sizeof(std::counted_iterator<int*>));
-- 
2.28.0.618.g9bc233ae1c


  reply	other threads:[~2020-09-28  4:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-28  4:48 [PATCH 1/4] libstdc++: Reduce the size of an unbounded iota_view Patrick Palka
2020-09-28  4:48 ` Patrick Palka [this message]
2020-09-28  9:32   ` [PATCH 2/4] libstdc++: Reduce the size of a subrange with empty sentinel type Jonathan Wakely
2020-09-28  4:48 ` [PATCH 3/4] libstdc++: Add test that tracks range adaptors' sizes Patrick Palka
2020-09-28  9:32   ` Jonathan Wakely
2020-09-28  4:48 ` [PATCH 4/4] libstdc++: Rearrange some range adaptors' data members Patrick Palka
2020-09-28  9:34   ` Jonathan Wakely
2020-09-28 13:11     ` Patrick Palka
2020-09-28 15:38       ` Jonathan Wakely
2020-09-28  9:31 ` [PATCH 1/4] libstdc++: Reduce the size of an unbounded iota_view Jonathan Wakely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200928044854.46674-2-ppalka@redhat.com \
    --to=ppalka@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).