From: Jakub Jelinek <jakub@redhat.com>
To: Chung-Lin Tang <cltang@codesourcery.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
Tobias Burnus <tobias@codesourcery.com>,
Catherine Moore <clm@codesourcery.com>,
Thomas Schwinge <thomas@codesourcery.com>
Subject: Re: [PATCH, 1/3, OpenMP] Target mapping changes for OpenMP 5.0, front-end parts
Date: Tue, 29 Sep 2020 12:16:16 +0200 [thread overview]
Message-ID: <20200929101616.GY2176@tucnak> (raw)
In-Reply-To: <639a56ef-eeed-eb38-8a19-f5cf8d082973@codesourcery.com>
On Tue, Sep 01, 2020 at 09:16:23PM +0800, Chung-Lin Tang wrote:
> this patch set implements parts of the target mapping changes introduced
> in OpenMP 5.0, mainly the attachment requirements for pointer-based
> list items, and the clause ordering.
>
> The first patch here are the C/C++ front-end changes.
Do you think you could mention in detail which exact target mapping changes
in the spec is the patchset attempting to implement?
5.0 unfortunately contains many target mapping changes and this patchset
can't implement them all and it would be easier to see the list of rules
(e.g. from openmp-diff-full-4.5-5.0.pdf, if you don't have that one, I can
send it to you), rather than trying to guess them from the patchset.
Thanks.
> gcc/c-family/
> * c-common.h (c_omp_adjust_clauses): New declaration.
> * c-omp.c (c_omp_adjust_clauses): New function.
This function name is too broad, it should have target in it as it is
for processing target* construct clauses only.
Jakub
next prev parent reply other threads:[~2020-09-29 10:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 13:16 Chung-Lin Tang
2020-09-16 14:11 ` Chung-Lin Tang
2020-09-29 10:16 ` Jakub Jelinek [this message]
2020-10-06 14:54 ` Chung-Lin Tang
2020-10-13 13:01 ` Jakub Jelinek
2020-10-28 10:31 ` Chung-Lin Tang
2020-10-29 11:44 ` Jakub Jelinek
2020-11-03 18:02 ` Chung-Lin Tang
2020-11-06 9:52 ` Jakub Jelinek
2021-06-04 12:18 ` [PATCH] openmp: Call c_omp_adjust_map_clauses even for combined target [PR100902] Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929101616.GY2176@tucnak \
--to=jakub@redhat.com \
--cc=clm@codesourcery.com \
--cc=cltang@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=thomas@codesourcery.com \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).