From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id CEBA53858C27 for ; Tue, 29 Sep 2020 10:16:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CEBA53858C27 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-103-kjAX08AuNje1ATQ7sZBfzw-1; Tue, 29 Sep 2020 06:16:24 -0400 X-MC-Unique: kjAX08AuNje1ATQ7sZBfzw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 541E1109106E; Tue, 29 Sep 2020 10:16:23 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-112-37.ams2.redhat.com [10.36.112.37]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B4D6260C84; Tue, 29 Sep 2020 10:16:22 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id 08TAGJ4j015162; Tue, 29 Sep 2020 12:16:19 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id 08TAGGuM015161; Tue, 29 Sep 2020 12:16:16 +0200 Date: Tue, 29 Sep 2020 12:16:16 +0200 From: Jakub Jelinek To: Chung-Lin Tang Cc: gcc-patches , Tobias Burnus , Catherine Moore , Thomas Schwinge Subject: Re: [PATCH, 1/3, OpenMP] Target mapping changes for OpenMP 5.0, front-end parts Message-ID: <20200929101616.GY2176@tucnak> Reply-To: Jakub Jelinek References: <639a56ef-eeed-eb38-8a19-f5cf8d082973@codesourcery.com> MIME-Version: 1.0 In-Reply-To: <639a56ef-eeed-eb38-8a19-f5cf8d082973@codesourcery.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Sep 2020 10:16:30 -0000 On Tue, Sep 01, 2020 at 09:16:23PM +0800, Chung-Lin Tang wrote: > this patch set implements parts of the target mapping changes introduced > in OpenMP 5.0, mainly the attachment requirements for pointer-based > list items, and the clause ordering. > > The first patch here are the C/C++ front-end changes. Do you think you could mention in detail which exact target mapping changes in the spec is the patchset attempting to implement? 5.0 unfortunately contains many target mapping changes and this patchset can't implement them all and it would be easier to see the list of rules (e.g. from openmp-diff-full-4.5-5.0.pdf, if you don't have that one, I can send it to you), rather than trying to guess them from the patchset. Thanks. > gcc/c-family/ > * c-common.h (c_omp_adjust_clauses): New declaration. > * c-omp.c (c_omp_adjust_clauses): New function. This function name is too broad, it should have target in it as it is for processing target* construct clauses only. Jakub