From: Jan Hubicka <hubicka@ucw.cz>
To: Martin Jambor <mjambor@suse.cz>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH 5/6] ipa-cp: Add dumping of overall_size after cloning
Date: Tue, 29 Sep 2020 20:39:35 +0200 [thread overview]
Message-ID: <20200929183935.GC7702@kam.mff.cuni.cz> (raw)
In-Reply-To: <bb1a73874a6c9a8a59e9c1532b517f52513d980e.1601403165.git.mjambor@suse.cz>
> When experimenting with IPA-CP parameters, especially when looking
> into exchange2_r, it has been very useful to know what the value of
> overall_size is at different stages of the decision process. This
> patch therefore adds it to the generated dumps.
>
> gcc/ChangeLog:
>
> 2020-09-07 Martin Jambor <mjambor@suse.cz>
>
> * ipa-cp.c (estimate_local_effects): Add overeall_size to dumped
> string.
> (decide_about_value): Add dumping new overall_size.
OK,
thanks
Honza
> ---
> gcc/ipa-cp.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/gcc/ipa-cp.c b/gcc/ipa-cp.c
> index f6320c787de..12acf24c553 100644
> --- a/gcc/ipa-cp.c
> +++ b/gcc/ipa-cp.c
> @@ -3517,7 +3517,8 @@ estimate_local_effects (struct cgraph_node *node)
>
> if (dump_file)
> fprintf (dump_file, " Decided to specialize for all "
> - "known contexts, growth deemed beneficial.\n");
> + "known contexts, growth (to %li) deemed "
> + "beneficial.\n", overall_size);
> }
> else if (dump_file && (dump_flags & TDF_DETAILS))
> fprintf (dump_file, " Not cloning for all contexts because "
> @@ -5506,6 +5507,9 @@ decide_about_value (struct cgraph_node *node, int index, HOST_WIDE_INT offset,
> val->spec_node = create_specialized_node (node, known_csts, known_contexts,
> aggvals, callers);
> overall_size += val->local_size_cost;
> + if (dump_file && (dump_flags & TDF_DETAILS))
> + fprintf (dump_file, " overall size reached %li\n",
> + overall_size);
>
> /* TODO: If for some lattice there is only one other known value
> left, make a special node for it too. */
> --
> 2.28.0
>
next prev parent reply other threads:[~2020-09-29 18:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 18:12 [PATCH 0/6] IPA cleanups and IPA-CP improvements for 548.exchange2_r Martin Jambor
2020-09-21 14:25 ` [PATCH 5/6] ipa-cp: Add dumping of overall_size after cloning Martin Jambor
2020-09-29 18:39 ` Jan Hubicka [this message]
2020-09-21 14:25 ` [PATCH 4/6] ipa: Multiple predicates for loop properties, with frequencies Martin Jambor
2020-09-29 22:18 ` Jan Hubicka
2020-10-02 12:31 ` Martin Jambor
2020-09-21 14:25 ` [PATCH 6/6] ipa-cp: Separate and increase the large-unit parameter Martin Jambor
2020-09-29 19:30 ` Jan Hubicka
2020-09-30 6:35 ` Richard Biener
2020-09-30 16:39 ` Martin Jambor
2020-10-26 11:00 ` Tamar Christina
2020-09-28 18:47 ` [PATCH 1/6] ipa: Bundle vectors describing argument values Martin Jambor
2020-10-02 11:54 ` Jan Hubicka
2020-09-28 18:47 ` [PATCH 3/6] ipa: Bundle estimates of ipa_call_context::estimate_size_and_time Martin Jambor
2020-09-29 18:39 ` Jan Hubicka
2020-09-28 18:47 ` [PATCH 2/6] ipa: Introduce ipa_cached_call_context Martin Jambor
2020-09-29 18:27 ` Jan Hubicka
-- strict thread matches above, loose matches on Subject: below --
2020-09-07 19:38 [PATCH 5/6] ipa-cp: Add dumping of overall_size after cloning Martin Jambor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200929183935.GC7702@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=mjambor@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).