From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 8B65C384403D for ; Fri, 2 Oct 2020 10:42:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8B65C384403D Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-310-z17bz6Q9OkeOhqBECevL7Q-1; Fri, 02 Oct 2020 06:42:12 -0400 X-MC-Unique: z17bz6Q9OkeOhqBECevL7Q-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 47E321006701; Fri, 2 Oct 2020 10:42:11 +0000 (UTC) Received: from localhost (unknown [10.33.36.3]) by smtp.corp.redhat.com (Postfix) with ESMTP id EE25F5C1D0; Fri, 2 Oct 2020 10:42:10 +0000 (UTC) Date: Fri, 2 Oct 2020 11:42:10 +0100 From: Jonathan Wakely To: gcc-patches@gcc.gnu.org Subject: [PATCH] testsuite: Fix FAIL for older ARM cores Message-ID: <20201002104210.GA606642@redhat.com> MIME-Version: 1.0 X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="sm4nu43k4a2Rpi4c" Content-Disposition: inline X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Oct 2020 10:42:15 -0000 --sm4nu43k4a2Rpi4c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Since hard-float is not implemented for cores that only support thumb1 (and not thumb2) this test fails for configurations using hard float but older -mcpu settings. gcc/testsuite/ChangeLog: * g++.dg/inherit/thunk10.C: Skip test for arm_hf_eabi if -mthumb doesn't generate thumb2 instructions. Tested x86_64-linux, and armv7l-linux-gnueabihf with RUNTESTFLAGS='--target_board=unix\{,-mcpu=cortex-a9\} No change for x86_64, for ARM this test goes from: PASS: 8 UNRESOLVED: 4 FAIL: 4 to UNSUPPORTED: 4 PASS: 8 OK for trunk? --sm4nu43k4a2Rpi4c Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="patch.txt" commit ce743e1768c75445a9bf8e49d1116b4a7ce99cfc Author: Jonathan Wakely Date: Fri Oct 2 11:30:51 2020 testsuite: Fix FAIL for older ARM cores Since hard-float is not implemented for cores that only support thumb1 (and not thumb2) this test fails for configurations using hard float but older -mcpu settings. gcc/testsuite/ChangeLog: * g++.dg/inherit/thunk10.C: Skip test for arm_hf_eabi if -mthumb doesn't generate thumb2 instructions. diff --git a/gcc/testsuite/g++.dg/inherit/thunk10.C b/gcc/testsuite/g++.dg/inherit/thunk10.C index 702067749fa..0188436b6cd 100644 --- a/gcc/testsuite/g++.dg/inherit/thunk10.C +++ b/gcc/testsuite/g++.dg/inherit/thunk10.C @@ -1,4 +1,5 @@ /* { dg-options "-mthumb" { target arm*-*-* } } */ +/* { dg-skip-if "hf needs thumb2" { arm_hf_eabi && { ! arm_thumb2_ok } } } */ /* { dg-do run } */ /* { dg-timeout 100 } */ --sm4nu43k4a2Rpi4c--