From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150082.outbound.protection.outlook.com [40.107.15.82]) by sourceware.org (Postfix) with ESMTPS id D20B8383E82D for ; Mon, 5 Oct 2020 16:28:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D20B8383E82D Received: from AM6P195CA0084.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::25) by VI1PR08MB4016.eurprd08.prod.outlook.com (2603:10a6:803:ed::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.38; Mon, 5 Oct 2020 16:28:33 +0000 Received: from AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:86:cafe::51) by AM6P195CA0084.outlook.office365.com (2603:10a6:209:86::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.32 via Frontend Transport; Mon, 5 Oct 2020 16:28:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;gcc.gnu.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT030.mail.protection.outlook.com (10.152.16.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.34 via Frontend Transport; Mon, 5 Oct 2020 16:28:33 +0000 Received: ("Tessian outbound 7a6fb63c1e64:v64"); Mon, 05 Oct 2020 16:28:33 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: e451b531016b8d49 X-CR-MTA-TID: 64aa7808 Received: from d4a391cc02e7.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 269F798A-C363-40AC-9813-2A0BECB22201.1; Mon, 05 Oct 2020 16:28:17 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d4a391cc02e7.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 05 Oct 2020 16:28:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SN3oHRPbjyPRUhrrHFNAYD9jqtUEiKlQjHRls4d3aDus155ku2oFVVsYC8AL31ialrEEVK1itgk1GXs62e87Iy/OD0gXYbOo8l3CS5kogegk2AGD8GNBSJh8lyo2k+NRdMuBl6vDeatEuQJeZDKJxwBIOjiecdnP0tUGDudngcKBfuqNa7Zz/pJZmJM8WIV8dvat0efg52MFK8SONHwxHOMSEZvlVLC9jxCfEv2ba9QEAbUJNXfR8L+YOBHKwMmtwGrxymB1JzASXhIh6STy0bwVTMDk6lj4PRWOvZRop99b0ixhGTDyrXBmUjK8rCSdJWekcR8wD+EUwg2roZgX5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3XPn/gJGAxmR1NN+ycPLQJibBiD8trZxkEGCR1kSWWg=; b=Jrg8hPqVoc0AT93sQkP5wExixBp+2Uhvm69r+sMyUgyocobs+tIu3NZeCVnfZ6yztdHzA9IQVEQiROQt8XKMDtjrcpODuOG73oNRfusB1v3hd2NSjYCt0Sf4UmmViVP4Yd4S59Y1ViIU26sd6IUqj8vXDk1hD/2E2cgLZYpErzIujdEXeblMsary4lWsdjQv3Xvftrva03VFqOb5AGFqSAs++2/NOR8TRqCLiyvCjFoFF3w7jXLKl+exwwLEdim6sTRKEoWCapFspksJh7FWMjdG1WVRic+MLxu9NtfkV9rEYsNxXslISg2Df5MXEIl3VMGUntBGvO2rJh6q5psylQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from PR3PR08MB5564.eurprd08.prod.outlook.com (2603:10a6:102:87::18) by PR3PR08MB5641.eurprd08.prod.outlook.com (2603:10a6:102:91::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.34; Mon, 5 Oct 2020 16:28:16 +0000 Received: from PR3PR08MB5564.eurprd08.prod.outlook.com ([fe80::784a:eb50:9684:50fe]) by PR3PR08MB5564.eurprd08.prod.outlook.com ([fe80::784a:eb50:9684:50fe%7]) with mapi id 15.20.3433.044; Mon, 5 Oct 2020 16:28:16 +0000 Date: Mon, 5 Oct 2020 17:28:07 +0100 From: Szabolcs Nagy To: Vaseeharan Vinayagamoorthy Cc: Jan Hubicka , "gcc-patches@gcc.gnu.org" , "d@dcepelik.cz" Subject: Re: Fix handling of stores in modref_summary::useful_p Message-ID: <20201005162807.GJ29000@arm.com> References: <20200927214600.GC52458@kam.mff.cuni.cz> <450AFC6D-9576-4F3C-86DE-86E8F70E703B@arm.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <450AFC6D-9576-4F3C-86DE-86E8F70E703B@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [217.140.106.54] X-ClientProxiedBy: DM6PR13CA0005.namprd13.prod.outlook.com (2603:10b6:5:bc::18) To PR3PR08MB5564.eurprd08.prod.outlook.com (2603:10a6:102:87::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from arm.com (217.140.106.54) by DM6PR13CA0005.namprd13.prod.outlook.com (2603:10b6:5:bc::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.13 via Frontend Transport; Mon, 5 Oct 2020 16:28:14 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 91596b06-d7ea-4ced-85d0-08d8694bb417 X-MS-TrafficTypeDiagnostic: PR3PR08MB5641:|VI1PR08MB4016: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:341;OLM:341; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: dC/O1CWckpdTbl9xObxmFLLd6Kjpxc0aUrdpkz8iS4oYv5BjRYoGia33Xe7E2BZORcMTVuPkArgy4sJ4qnT1zS4cendFIpGkK0FpAz+a4zz3SRD4VsHhQJCS9yOO/BV35OQfVAa3np8PF+iBrkUiuuLAcHR6Jzjg3U/FAEbIwaS66Iw6Nvjd3a/df34SpC8spkm0YDk8/rEPcaB/ACxbmUb1YwLK9exPHipF3DkZ+1zpM96t9iC4F3BswS9G/iPJBole7Sca8AB0DYLnoeqsdlPzgdabeadwds9V3sl59FrMMhBIw4dwDPtGFt4d7suNFsOAFcnJYGiQkQo5HRF94w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PR3PR08MB5564.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(39860400002)(366004)(346002)(376002)(52116002)(478600001)(8676002)(5660300002)(316002)(36756003)(6636002)(55016002)(2616005)(956004)(2906002)(7696005)(1076003)(8936002)(66556008)(66476007)(186003)(26005)(16526019)(6666004)(6862004)(4326008)(66946007)(33656002)(54906003)(37006003)(8886007)(86362001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: JCScWyBmPlXOoYFO4X90fxVtWW77p9N8sArBIabfzfdXLmW8V3tpdDGUNqbjfXg8W1IT6GQ2EAYtC9njcubqFL+Ehefa7Qhp/EP8z4DfNNnsEXXH+L+9TJfs7amCR06O8ZMLF2SafX001VlSLpAh7FPePlTioy5ZcA/ougnm5jLCPnt0lTXrvXmFxwL6Ympm3axH0hrQ6Tk2FMqtIiyWm0OAK5viTacWLJV7wPrCO1J9WeNEnCJ1V5ltBqhlcuPDE2kOrTRDzUusSqoeK1wa04V89t1bO++9f3yL9MSI7TBkl8hnt+e23UJv+OUe236d1rhAoc++jTFDVrQH0dudXp08WfQxTU3uY7Sd0f+/XX9yZAA8PTt3P2Bd3KrVFdyiczYmHT7VKOvFvUa+vyeNeNgThyOmK5zSWq/7/EQcBLXXk2Gn+CFG47Cw1Mj/k7o/XnhhY2Z2sMArSMThXxLudCsnk7NwXzNOJpl/IukecvB8YGdRvSL5F7WLMmL4aDdm8tk3UhpFENH5pIOPILvH4QEKLd7ywBh3V6o0oQoKOQEI4r1TSZ1IiLt3UOVP5a5tTBdbcovAG1L08rxwtaOqn0ZnOllXPJBxf9QuucpXolnx98AFZs3mX2pfG4fyn52g9Zjuw7AgdwOcJLxAtiN+SA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5641 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: b0b943c5-af36-4fde-f98a-08d8694ba946 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OvKXTkf68wRP+k1UPjTSazoxpul3CQ1Dp1EtsLZsnddo9Clc9DoD2skEOZsyP9+XhqtK9v6zEqiUZHOw22iUFNj33/F4QTfk6WtJTyXjtTqot8otqNCylxzelHwfUxZYB/GtwnQ259doXZTn8nwGWqJqUw78hJk1r5UWOKIvVAwoiBxPxDqnbgV7LxE1gSKPmNAiLWx55pYf0tMo2KsMoZaBReQ4DNcJzNriw+3A5d/lBmeLxb7oaFmjANMaIeR0SNYSBat9sMB3VvxSZ23bBo/J/4FTwP02mturrx3wTpu7250WBxiQh443O8ndB/+BVrgsLLx/cKCV/U5NudPX6+XW8F+oDiS+jXe+NetDbcS88aVV1V3y+rsQ3lvS3ReGltSQE0B5eLWko89QtKOWXQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(396003)(136003)(376002)(39860400002)(346002)(46966005)(81166007)(55016002)(8936002)(336012)(33656002)(26005)(107886003)(82740400003)(47076004)(956004)(2616005)(356005)(186003)(16526019)(1076003)(37006003)(36906005)(7696005)(54906003)(316002)(86362001)(6636002)(2906002)(82310400003)(70206006)(478600001)(6666004)(8676002)(8886007)(6862004)(36756003)(4326008)(5660300002)(70586007); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2020 16:28:33.7190 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 91596b06-d7ea-4ced-85d0-08d8694bb417 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4016 X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Oct 2020 16:28:40 -0000 The 10/05/2020 12:52, Vaseeharan Vinayagamoorthy wrote: > Hi, > > After this patch, I am noticing that some glibc crypto tests get stuck in scanf which goes into busy loop. > > My build/host/target setup is: > Build: aarch64-none-linux-gnu > Host: aarch64-none-linux-gnu > Target: aarch64-none-linux-gnu i can reproduce this on aarch64, i'm looking at it: if i compile glibc with gcc trunk after this commit i see $ ./testrun.sh crypt/cert < $glibcsrc/crypt/cert.input K: 0000000000000000 P: 0000000000000000 C: 0000000000000000 Encrypt FAIL K: 0000000000000000 P: 0000000000000000 C: 0000000000000000 Encrypt FAIL K: 0000000000000000 P: 0000000000000000 C: 0000000000000000 Encrypt FAIL K: 0000000000000000 P: 0000000000000000 C: 0000000000000000 Encrypt FAIL K: 0000000000000000 P: 0000000000000000 C: 0000000000000000 Encrypt FAIL K: 0000000000000000 P: 0000000000000000 C: 0000000000000000 Encrypt FAIL ... it just keeps printing this. same test binary with glibc code compiled with an older gcc works, so something in glibc gets miscompiled. i will have to do more digging to figure out what. > > > > Kind regards > Vasee > > > On 27/09/2020, 22:46, "Gcc-patches on behalf of Jan Hubicka" wrote: > > Hi, > this patch fixes a pasto in modref_summary::useful_p that made > ipa-modref to give up on tracking stores when all load info got lost. > > Bootstrapped/regtested x86_64-linux, comitted. > > gcc/ChangeLog: > > 2020-09-27 Jan Hubicka > > * ipa-modref.c (modref_summary::useful_p): Fix testing of stores. > > diff --git a/gcc/ipa-modref.c b/gcc/ipa-modref.c > index 728c6c1523d..6225552e41a 100644 > --- a/gcc/ipa-modref.c > +++ b/gcc/ipa-modref.c > @@ -135,7 +135,7 @@ modref_summary::useful_p (int ecf_flags) > return true; > if (ecf_flags & ECF_PURE) > return false; > - return stores && !loads->every_base; > + return stores && !stores->every_base; > } > > /* Dump A to OUT. */ > --