From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jwakely@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [63.128.21.124])
 by sourceware.org (Postfix) with ESMTP id 537DA3857013
 for <gcc-patches@gcc.gnu.org>; Tue,  6 Oct 2020 20:04:46 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 537DA3857013
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-450-bkJ1WmzON7OCTwVFxjcaKA-1; Tue, 06 Oct 2020 16:04:44 -0400
X-MC-Unique: bkJ1WmzON7OCTwVFxjcaKA-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com
 [10.5.11.14])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 52BFC835B74;
 Tue,  6 Oct 2020 20:04:42 +0000 (UTC)
Received: from localhost (unknown [10.33.37.1])
 by smtp.corp.redhat.com (Postfix) with ESMTP id E152C5D9CD;
 Tue,  6 Oct 2020 20:04:41 +0000 (UTC)
Date: Tue, 6 Oct 2020 21:04:41 +0100
From: Jonathan Wakely <jwakely@redhat.com>
To: lemire@gmail.com
Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH, libstdc++] Improve the performance of
 std::uniform_int_distribution (fewer divisions)
Message-ID: <20201006200441.GI7004@redhat.com>
References: <CAJ0XVj1YOGT-pnzwnge7Wr8rC-0DxaONw20YWasgHhDgL02ATw@mail.gmail.com>
 <CAJ0XVj2xcKmDppxQa6Lht758TWQpykJ1XX2+b4Z9fN2TFcZKzA@mail.gmail.com>
 <20201005232515.GD7004@redhat.com>
 <20201005234031.GF7004@redhat.com>
 <CAJ0XVj18JZEcTZk8v5m5PSnMtTVv8EGLnLO4-Jj_Sq_-VmQ3Mg@mail.gmail.com>
MIME-Version: 1.0
In-Reply-To: <CAJ0XVj18JZEcTZk8v5m5PSnMtTVv8EGLnLO4-Jj_Sq_-VmQ3Mg@mail.gmail.com>
X-Clacks-Overhead: GNU Terry Pratchett
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE,
 RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Oct 2020 20:04:47 -0000

On 06/10/20 15:55 -0400, Daniel Lemire via Libstdc++ wrote:
>The updated patch looks good to me. It is indeed cleaner to have a separate
>(static) function.
>
>It might be nice to add a comment to explain the _S_nd function maybe with
>a comment like "returns a random value in [0,__range)
>without any bias" (or something to that effect).

Indeed. My current local branch has this comment on _S_nd:

+      // Lemire's nearly divisionless algorithm.
+      // Returns a random number from __g downscaled to [0,__range)
+      // using an unsigned type _Wp twice as wide as unsigned type _Up.

I think "Returns an unbiased random number from ..." would be an
improvement.

>Otherwise, it is algorithmically correct.

Great, thanks for the review.

I'll get it committed tomorrow then. Thanks for the patch, and sorry
it took so long.