public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH] rs6000: Fix extraneous characters in the documentation
@ 2020-08-19 19:03 Tulio Magno Quites Machado Filho
  2020-10-05 20:23 ` Tulio Magno Quites Machado Filho
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Tulio Magno Quites Machado Filho @ 2020-08-19 19:03 UTC (permalink / raw)
  To: gcc-patches

Replace them with a whitespace in order to avoid artifacts in the HTML
document.

2020-08-19  Tulio Magno Quites Machado Filho  <tuliom@linux.ibm.com>

gcc/
	* doc/extend.texi (PowerPC Built-in Functions): Replace
	extraneous characters with whitespace.
---
 gcc/doc/extend.texi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi
index bcc251481ca..0c380322280 100644
--- a/gcc/doc/extend.texi
+++ b/gcc/doc/extend.texi
@@ -21538,10 +21538,10 @@ void amo_stdat_smin (int64_t *, int64_t);
 ISA 3.1 of the PowerPC added new Matrix-Multiply Assist (MMA) instructions.
 GCC provides support for these instructions through the following built-in
 functions which are enabled with the @code{-mmma} option.  The vec_t type
-below is defined to be a normal vector unsigned char type.  The uint2, uint4
+below is defined to be a normal vector unsigned char type.  The uint2, uint4
 and uint8 parameters are 2-bit, 4-bit and 8-bit unsigned integer constants
-respectively.  The compiler will verify that they are constants and that
-their values are within range. 
+respectively.  The compiler will verify that they are constants and that
+their values are within range.
 
 The built-in functions supported are:
 
-- 
2.25.4


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] rs6000: Fix extraneous characters in the documentation
  2020-08-19 19:03 [PATCH] rs6000: Fix extraneous characters in the documentation Tulio Magno Quites Machado Filho
@ 2020-10-05 20:23 ` Tulio Magno Quites Machado Filho
  2020-10-06 15:29   ` will schmidt
  2020-10-07 23:48 ` Segher Boessenkool
  2020-10-23 15:12 ` Segher Boessenkool
  2 siblings, 1 reply; 5+ messages in thread
From: Tulio Magno Quites Machado Filho @ 2020-10-05 20:23 UTC (permalink / raw)
  To: gcc-patches

Ping?

Tulio Magno Quites Machado Filho via Gcc-patches <gcc-patches@gcc.gnu.org> writes:

> Replace them with a whitespace in order to avoid artifacts in the HTML
> document.
>
> 2020-08-19  Tulio Magno Quites Machado Filho  <tuliom@linux.ibm.com>
>
> gcc/
> 	* doc/extend.texi (PowerPC Built-in Functions): Replace
> 	extraneous characters with whitespace.
> ---
>  gcc/doc/extend.texi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi
> index bcc251481ca..0c380322280 100644
> --- a/gcc/doc/extend.texi
> +++ b/gcc/doc/extend.texi
> @@ -21538,10 +21538,10 @@ void amo_stdat_smin (int64_t *, int64_t);
>  ISA 3.1 of the PowerPC added new Matrix-Multiply Assist (MMA) instructions.
>  GCC provides support for these instructions through the following built-in
>  functions which are enabled with the @code{-mmma} option.  The vec_t type
> -below is defined to be a normal vector unsigned char type.  The uint2, uint4
> +below is defined to be a normal vector unsigned char type.  The uint2, uint4
>  and uint8 parameters are 2-bit, 4-bit and 8-bit unsigned integer constants
> -respectively.  The compiler will verify that they are constants and that
> -their values are within range. 
> +respectively.  The compiler will verify that they are constants and that
> +their values are within range.
>  
>  The built-in functions supported are:
>  
> -- 
> 2.25.4
>

-- 
Tulio Magno

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] rs6000: Fix extraneous characters in the documentation
  2020-10-05 20:23 ` Tulio Magno Quites Machado Filho
@ 2020-10-06 15:29   ` will schmidt
  0 siblings, 0 replies; 5+ messages in thread
From: will schmidt @ 2020-10-06 15:29 UTC (permalink / raw)
  To: Tulio Magno Quites Machado Filho, gcc-patches; +Cc: Segher Boessenkool

On Mon, 2020-10-05 at 17:23 -0300, Tulio Magno Quites Machado Filho via Gcc-patches wrote:
> Ping?
+cc Segher  :-)

> 
> Tulio Magno Quites Machado Filho via Gcc-patches <gcc-patches@gcc.gnu.org> writes:
> 
> > Replace them with a whitespace in order to avoid artifacts in the HTML
> > document.
> > 
> > 2020-08-19  Tulio Magno Quites Machado Filho  <tuliom@linux.ibm.com>
> > 
> > gcc/
> > 	* doc/extend.texi (PowerPC Built-in Functions): Replace
> > 	extraneous characters with whitespace.
> > ---
> >  gcc/doc/extend.texi | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi
> > index bcc251481ca..0c380322280 100644
> > --- a/gcc/doc/extend.texi
> > +++ b/gcc/doc/extend.texi
> > @@ -21538,10 +21538,10 @@ void amo_stdat_smin (int64_t *, int64_t);
> >  ISA 3.1 of the PowerPC added new Matrix-Multiply Assist (MMA) instructions.
> >  GCC provides support for these instructions through the following built-in
> >  functions which are enabled with the @code{-mmma} option.  The vec_t type
> > -below is defined to be a normal vector unsigned char type.  The uint2, uint4
> > +below is defined to be a normal vector unsigned char type.  The uint2, uint4

That looks like a non-breaking space.  (ascii c2 a0) so 
2e c2 a0 20 becomes 2e 20 20 


> >  and uint8 parameters are 2-bit, 4-bit and 8-bit unsigned integer constants
> > -respectively.  The compiler will verify that they are constants and that
> > -their values are within range. 
> > +respectively.  The compiler will verify that they are constants and that
> > +their values are within range.

2e c2 a0 20 becomes 2e 20 20

And drops a trailing whitespace.

Those seem reasonable. 
lgtm

Thanks
-Will

> >  
> >  The built-in functions supported are:
> >  
> > -- 
> > 2.25.4
> > 
> 
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] rs6000: Fix extraneous characters in the documentation
  2020-08-19 19:03 [PATCH] rs6000: Fix extraneous characters in the documentation Tulio Magno Quites Machado Filho
  2020-10-05 20:23 ` Tulio Magno Quites Machado Filho
@ 2020-10-07 23:48 ` Segher Boessenkool
  2020-10-23 15:12 ` Segher Boessenkool
  2 siblings, 0 replies; 5+ messages in thread
From: Segher Boessenkool @ 2020-10-07 23:48 UTC (permalink / raw)
  To: Tulio Magno Quites Machado Filho; +Cc: gcc-patches

Hi!

On Wed, Aug 19, 2020 at 04:03:31PM -0300, Tulio Magno Quites Machado Filho via Gcc-patches wrote:
> Replace them with a whitespace in order to avoid artifacts in the HTML
> document.

Multiple whitespaces in texinfo are supposed to work correctly, and are
good to have for various reasons (more readable, and agrees to our
coding conventions, and it agrees to texinfo's output, too!)

But as Will says, there seem the be non-breaking space here, instead?

0000000: 3e20 2d62 656c 6f77 2069 7320 6465 6669  > -below is defi
0000010: 6e65 6420 746f 2062 6520 6120 6e6f 726d  ned to be a norm
0000020: 616c 2076 6563 746f 7220 756e 7369 676e  al vector unsign
0000030: 6564 2063 6861 7220 7479 7065 2ec2 a020  ed char type... 
0000040: 5468 6520 7569 6e74 322c 2075 696e 7434  The uint2, uint4
0000050: 0a                                       .

0000000: 3e20 2b62 656c 6f77 2069 7320 6465 6669  > +below is defi
0000010: 6e65 6420 746f 2062 6520 6120 6e6f 726d  ned to be a norm
0000020: 616c 2076 6563 746f 7220 756e 7369 676e  al vector unsign
0000030: 6564 2063 6861 7220 7479 7065 2e20 2054  ed char type.  T
0000040: 6865 2075 696e 7432 2c20 7569 6e74 340a  he uint2, uint4.

Yeah, utf8 c2 a0, aka u+00a0.  Replacing that with an actual space is of
course okay (and trivial and obvious).  Thanks!

(Bonus points if you do all of doc/*.texi :-) )


Segher

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] rs6000: Fix extraneous characters in the documentation
  2020-08-19 19:03 [PATCH] rs6000: Fix extraneous characters in the documentation Tulio Magno Quites Machado Filho
  2020-10-05 20:23 ` Tulio Magno Quites Machado Filho
  2020-10-07 23:48 ` Segher Boessenkool
@ 2020-10-23 15:12 ` Segher Boessenkool
  2 siblings, 0 replies; 5+ messages in thread
From: Segher Boessenkool @ 2020-10-23 15:12 UTC (permalink / raw)
  To: Tulio Magno Quites Machado Filho; +Cc: gcc-patches

On Wed, Aug 19, 2020 at 04:03:31PM -0300, Tulio Magno Quites Machado Filho via Gcc-patches wrote:
> Replace them with a whitespace in order to avoid artifacts in the HTML
> document.

Pushed to trunk now.  Thanks!


Segher

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-10-23 15:13 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-19 19:03 [PATCH] rs6000: Fix extraneous characters in the documentation Tulio Magno Quites Machado Filho
2020-10-05 20:23 ` Tulio Magno Quites Machado Filho
2020-10-06 15:29   ` will schmidt
2020-10-07 23:48 ` Segher Boessenkool
2020-10-23 15:12 ` Segher Boessenkool

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).