From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id 0BF03386184C for ; Thu, 8 Oct 2020 20:21:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0BF03386184C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=segher@kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 098KKN1s002143; Thu, 8 Oct 2020 15:20:23 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 098KKMAF002142; Thu, 8 Oct 2020 15:20:22 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Thu, 8 Oct 2020 15:20:22 -0500 From: Segher Boessenkool To: Alex Coplan Cc: gcc-patches@gcc.gnu.org Subject: Re: [PING][PATCH v2] combine: Don't turn (mult (extend x) 2^n) into extract [PR96998] Message-ID: <20201008202022.GJ2672@gate.crashing.org> References: <20200930103931.raxfvhpuehrgulcp@arm.com> <20201008102125.vh7qnmpr5alhp5sd@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201008102125.vh7qnmpr5alhp5sd@arm.com> User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, TXREP, T_SPF_HELO_PERMERROR, T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Oct 2020 20:21:27 -0000 On Thu, Oct 08, 2020 at 11:21:26AM +0100, Alex Coplan wrote: > Ping. The kernel is still broken on AArch64. You *cannot* fix a correctness bug with a combine addition. So please fix the target bug first. I haven't had time to look at your patch yet, sorry. Segher