* [Ada] Double evaluation of predicate
@ 2020-10-15 9:40 Pierre-Marie de Rodat
0 siblings, 0 replies; only message in thread
From: Pierre-Marie de Rodat @ 2020-10-15 9:40 UTC (permalink / raw)
To: gcc-patches; +Cc: Arnaud Charlet
[-- Attachment #1: Type: text/plain, Size: 435 bytes --]
In some case involving a type with a predicate and an inner package with
a subprogram referencing the type, GNAT would call Add_Predicate twice
on the same pragma node, causing tree sharing conflicts.
Tested on x86_64-pc-linux-gnu, committed on trunk
gcc/ada/
* sem_ch13.adb (Add_Predicates): Prevent analyzing twice the
same pragma in case an inner package references the type with a
predicate (as opposed to defining the type).
[-- Attachment #2: patch.diff --]
[-- Type: text/x-diff, Size: 524 bytes --]
diff --git a/gcc/ada/sem_ch13.adb b/gcc/ada/sem_ch13.adb
--- a/gcc/ada/sem_ch13.adb
+++ b/gcc/ada/sem_ch13.adb
@@ -9746,7 +9746,7 @@ package body Sem_Ch13 is
elsif Nkind (Ritem) = N_Aspect_Specification
and then Present (Aspect_Rep_Item (Ritem))
- and then Scope (Typ) /= Current_Scope
+ and then Scope_Depth (Scope (Typ)) > Scope_Depth (Current_Scope)
then
declare
Prag : constant Node_Id := Aspect_Rep_Item (Ritem);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-10-15 9:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-15 9:40 [Ada] Double evaluation of predicate Pierre-Marie de Rodat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).