From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by sourceware.org (Postfix) with ESMTPS id F3ECD385E83A for ; Wed, 21 Oct 2020 22:11:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F3ECD385E83A Received: by mail-pj1-x1044.google.com with SMTP id hk7so1864942pjb.2 for ; Wed, 21 Oct 2020 15:11:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=i3ncf3xEDOLa97zxhPTFDn1AfC8oJ7DCzlexMgb4YOE=; b=SgLB986zlhTshyTk6aDGZrOsHh+SjTfNeSfwB2c1YLgSRFGhth8teg0Y0eQbae8Xu/ 1qfqTeUwepTVyHNjclMtQ59rYbnz/oDRP8t+mDYzrIZz2pZKurhd0r9qv9NL8Cdo4Ofy FQg1CrblgR+g6b+W+aw4wDatYssUuqssve/CgjdUzyKnXWFM4bp93TVpsRK8I3hihm3m Z4/ryvaKpfijYxXxM/nvlwgvkBSSRfBEcBQBUj0a+I7Bh/NdHhWDwWrOJkNUv8YwGMhN dHjNopt4wNsflHUz+FBB9qDkKAWEfnbbWZe0OM4VVMQQIcdPgnbAmUbcjN0EN87HV/uU HB5g== X-Gm-Message-State: AOAM532De4hG5OCuynvDe7lIKqvPpA4RKVibwJlV8cs85dt8bgTXQgn8 CuFQzYCgk52+5a5Amxil5F53Rk/KOGi+OQ== X-Google-Smtp-Source: ABdhPJyCfWbz38OHvvMQyDvsJ5v8QBo4Z1ZuQdvL9axi8pRxkzJ7DZ5YKN65QUb8CyfqhV72ybUhMQ== X-Received: by 2002:a17:902:d303:b029:d5:fb58:1715 with SMTP id b3-20020a170902d303b02900d5fb581715mr5574671plc.45.1603318314756; Wed, 21 Oct 2020 15:11:54 -0700 (PDT) Received: from bubble.grove.modra.org ([2406:3400:51d:8cc0:cc7b:bb2a:7f79:8d0d]) by smtp.gmail.com with ESMTPSA id o15sm3699375pfp.91.2020.10.21.15.11.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Oct 2020 15:11:53 -0700 (PDT) Received: by bubble.grove.modra.org (Postfix, from userid 1000) id 36A6E858FB; Thu, 22 Oct 2020 08:41:50 +1030 (ACDT) Date: Thu, 22 Oct 2020 08:41:50 +1030 From: Alan Modra To: Segher Boessenkool Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 2/8] [RS6000] rs6000_rtx_costs for AND Message-ID: <20201021221150.GF4898@bubble.grove.modra.org> References: <20201007225800.9536-1-amodra@gmail.com> <20201007225800.9536-3-amodra@gmail.com> <20201020185556.GB2672@gate.crashing.org> <20201021025742.GD4898@bubble.grove.modra.org> <20201021202911.GK2672@gate.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201021202911.GK2672@gate.crashing.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Oct 2020 22:11:57 -0000 On Wed, Oct 21, 2020 at 03:29:11PM -0500, Segher Boessenkool wrote: > Anyway: > > + || (outer_code == AND > + && rs6000_is_valid_2insn_and (x, mode))) > { > *total = COSTS_N_INSNS (1); > return true; > > It should return COSTS_N_INSNS (2) for that? No, it should not! /* (reg) is costed at zero by rtlanal.c:rtx_cost. That sets a baseline for rtx costs: If a constant is valid in an insn, it is free. */ -- Alan Modra Australia Development Lab, IBM