From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 7EC463861843 for ; Sat, 24 Oct 2020 00:07:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7EC463861843 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-565-3-ykpB9SPn2-G2p6qjcxkA-1; Fri, 23 Oct 2020 20:07:06 -0400 X-MC-Unique: 3-ykpB9SPn2-G2p6qjcxkA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 90FD1805EF2; Sat, 24 Oct 2020 00:07:04 +0000 (UTC) Received: from redhat.com (ovpn-116-39.rdu2.redhat.com [10.10.116.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 225955C1C4; Sat, 24 Oct 2020 00:07:04 +0000 (UTC) Date: Fri, 23 Oct 2020 20:07:02 -0400 From: Marek Polacek To: Ville Voutilainen Cc: libstdc++ , gcc-patches List Subject: Re: [PATCH] g++, libstdc++: implement __is_nothrow_{constructible, assignable} Message-ID: <20201024000702.GR3628@redhat.com> References: <20201024000025.GP3628@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Oct 2020 00:07:09 -0000 On Sat, Oct 24, 2020 at 03:03:51AM +0300, Ville Voutilainen via Gcc-patches wrote: > On Sat, 24 Oct 2020 at 03:00, Marek Polacek wrote: > > > + tree expr; > > > + expr = is_xible_helper (code, to, from, /*trivial*/false); > > > > tree expr = is_xible_helper (code, to, from, /*trivial*/false); > > > > would be nicer, otherwise the front-end changes look fine, thanks. > > Ha, we have the same thing in is_trivially_xible, so I'll drive-by > change that one as well. Please. Thanks! Marek