From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id E37D93861810 for ; Mon, 26 Oct 2020 09:32:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org E37D93861810 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-430-P-XfekGFM1qav7weyVRhPQ-1; Mon, 26 Oct 2020 05:32:15 -0400 X-MC-Unique: P-XfekGFM1qav7weyVRhPQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AB3401084C84; Mon, 26 Oct 2020 09:32:14 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-112-37.ams2.redhat.com [10.36.112.37]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3E13319C66; Mon, 26 Oct 2020 09:32:14 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id 09Q9WBgu013444; Mon, 26 Oct 2020 10:32:11 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id 09Q9W9PZ013443; Mon, 26 Oct 2020 10:32:09 +0100 Date: Mon, 26 Oct 2020 10:32:09 +0100 From: Jakub Jelinek To: Kyrylo Tkachov Cc: "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH] PR tree-optimization/97546 Bail out of find_bswap_or_nop on non-INTEGER_CST sizes Message-ID: <20201026093209.GG7080@tucnak> Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Oct 2020 09:32:21 -0000 On Mon, Oct 26, 2020 at 09:20:42AM +0000, Kyrylo Tkachov via Gcc-patches wrote: > This patch fixes the ICE in the PR by bailing out of find_bswap_or_nop on poly_int sizes. > I don't think it intends to handle them and from my reading of the code it's the most appropriate place to reject them > here rather than in the callers. > > Bootstrapped and tested on aarch64-none-linux-gnu. > > Ok for trunk? > Thanks, > Kyrill > > gcc/ > PR tree-optimization/97546 > * gimple-ssa-store-merging.c (find_bswap_or_nop): Return NULL if type is > not INTEGER_CST. I think better use tree_fits_uhwi_p instead of cst_and_fits_hwi and instead of TREE_INT_CST_LOW use tree_to_uhwi. TYPE_SIZE_UNIT which doesn't fit into uhwi but fits into shwi is something that really shouldn't appear. Otherwise LGTM. > gcc/testsuite/ > PR tree-optimization/97546 > * gcc.target/aarch64/sve/acle/general/pr97546.c: New test. Jakub