From: Jakub Jelinek <jakub@redhat.com>
To: Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] PR tree-optimization/97546 Bail out of find_bswap_or_nop on non-INTEGER_CST sizes
Date: Mon, 26 Oct 2020 12:34:58 +0100 [thread overview]
Message-ID: <20201026113458.GH7080@tucnak> (raw)
In-Reply-To: <DB7PR08MB3002A939F3220D601DC0879493190@DB7PR08MB3002.eurprd08.prod.outlook.com>
On Mon, Oct 26, 2020 at 11:32:43AM +0000, Kyrylo Tkachov wrote:
> Thanks, that makes sense.
> Is the attached patch ok?
--- a/gcc/gimple-ssa-store-merging.c
+++ b/gcc/gimple-ssa-store-merging.c
@@ -851,12 +851,16 @@ find_bswap_or_nop_finalize (struct symbolic_number *n, uint64_t *cmpxchg,
gimple *
find_bswap_or_nop (gimple *stmt, struct symbolic_number *n, bool *bswap)
{
+ tree type_size = TYPE_SIZE_UNIT (gimple_expr_type (stmt));
+ if (!tree_fits_uhwi_p (type_size))
+ return NULL;
Just one space before ( above. Ok for trunk with that nit fixed.
Thanks.
Jakub
prev parent reply other threads:[~2020-10-26 11:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 9:20 Kyrylo Tkachov
2020-10-26 9:32 ` Jakub Jelinek
2020-10-26 11:32 ` Kyrylo Tkachov
2020-10-26 11:34 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026113458.GH7080@tucnak \
--to=jakub@redhat.com \
--cc=Kyrylo.Tkachov@arm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).