From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jwakely@redhat.com>
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by sourceware.org (Postfix) with ESMTP id 47F60388EC3E
 for <gcc-patches@gcc.gnu.org>; Mon, 26 Oct 2020 12:22:34 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 47F60388EC3E
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-105-rIQzkF0GPqKnfFfgfo8e8g-1; Mon, 26 Oct 2020 08:22:32 -0400
X-MC-Unique: rIQzkF0GPqKnfFfgfo8e8g-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com
 [10.5.11.22])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3650C186DD2E;
 Mon, 26 Oct 2020 12:22:31 +0000 (UTC)
Received: from localhost (unknown [10.33.36.3])
 by smtp.corp.redhat.com (Postfix) with ESMTP id AD8D110013D9;
 Mon, 26 Oct 2020 12:22:30 +0000 (UTC)
Date: Mon, 26 Oct 2020 12:22:29 +0000
From: Jonathan Wakely <jwakely@redhat.com>
To: Ville Voutilainen <ville.voutilainen@gmail.com>
Cc: gcc-patches List <gcc-patches@gcc.gnu.org>,
 libstdc++ <libstdc++@gcc.gnu.org>, Jason Merrill <jason@redhat.com>
Subject: Re: [PATCH] g++, libstdc++: implement __is_nothrow_{constructible,
 assignable}
Message-ID: <20201026122229.GA1836222@redhat.com>
References: <CAFk2RUbOhSTJ4uBV=3Pc0NDBfg0ovDCXxG01yg0zZb50eBSwug@mail.gmail.com>
MIME-Version: 1.0
In-Reply-To: <CAFk2RUbOhSTJ4uBV=3Pc0NDBfg0ovDCXxG01yg0zZb50eBSwug@mail.gmail.com>
X-Clacks-Overhead: GNU Terry Pratchett
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE,
 RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Oct 2020 12:22:35 -0000

On 24/10/20 02:32 +0300, Ville Voutilainen via Libstdc++ wrote:
>@@ -1118,15 +1080,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
>     };
> 
>   template<typename _Tp, typename _Up>
>-    struct __is_nt_assignable_impl
>-    : public integral_constant<bool, noexcept(declval<_Tp>() = declval<_Up>())>
>-    { };
>-
>-  template<typename _Tp, typename _Up>
>-    struct __is_nothrow_assignable_impl
>-    : public __and_<__bool_constant<__is_assignable(_Tp, _Up)>,
>-		    __is_nt_assignable_impl<_Tp, _Up>>
>-    { };
>+    using __is_nothrow_assignable_impl
>+    = __bool_constant<__is_nothrow_assignable(_Tp, _Up)>;

Please indent the "= __bool_constant<...>;" line two more spaces,
rather than lining it up with the "using".

The library changes are OK with that tweak. Thanks!