From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by sourceware.org (Postfix) with ESMTP id 487EA38930C6 for ; Mon, 26 Oct 2020 12:34:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 487EA38930C6 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=segher@kernel.crashing.org Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 09QCXnuX019235; Mon, 26 Oct 2020 07:33:49 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 09QCXnpp019234; Mon, 26 Oct 2020 07:33:49 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Mon, 26 Oct 2020 07:33:49 -0500 From: Segher Boessenkool To: Alan Modra Cc: gcc-patches@gcc.gnu.org, David Edelsohn Subject: Re: [RS6000] Tests that use int128_t and -m32 Message-ID: <20201026123349.GU2672@gate.crashing.org> References: <20201025112001.GC15956@bubble.grove.modra.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201025112001.GC15956@bubble.grove.modra.org> User-Agent: Mutt/1.4.2.3i X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, KAM_NUMSUBJECT, TXREP, T_SPF_HELO_PERMERROR, T_SPF_PERMERROR autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Oct 2020 12:34:51 -0000 Hi Alan, On Sun, Oct 25, 2020 at 09:50:01PM +1030, Alan Modra wrote: > All these tests fail with -m32 due to lack of int128 support, Is there any good reason __int128 is not enabled for rs6000 -m32, btw? > in some > cases with what I thought was not the best error message. For example > vsx_mask-move-runnable.c:34:3: error: unknown type name 'vector' > is misleading. The problem isn't "vector" but "vector __uint128_t". Ouch, yes. Do you see a simple way to fix that? > diff --git a/gcc/testsuite/gcc.target/powerpc/vsx-load-element-extend-char.c b/gcc/testsuite/gcc.target/powerpc/vsx-load-element-extend-char.c > index 0b8cfd610f8..7a7cb77c3a0 100644 > --- a/gcc/testsuite/gcc.target/powerpc/vsx-load-element-extend-char.c > +++ b/gcc/testsuite/gcc.target/powerpc/vsx-load-element-extend-char.c > @@ -4,6 +4,7 @@ > > /* { dg-do compile {target power10_ok} } */ > /* { dg-do run {target power10_hw} } */ > +/* { dg-require-effective-target { int128 } } */ > /* { dg-options "-mdejagnu-cpu=power10 -O3" } */ You might want to write this as {int128}, to keep the same style as the other statements. Or leave off the braces completely, they aren't necessary here, int128 is a single word :-) > diff --git a/gcc/testsuite/gcc.target/powerpc/vsx_mask-count-runnable.c b/gcc/testsuite/gcc.target/powerpc/vsx_mask-count-runnable.c > index 5862517eae9..6ac4ed2173f 100644 > --- a/gcc/testsuite/gcc.target/powerpc/vsx_mask-count-runnable.c > +++ b/gcc/testsuite/gcc.target/powerpc/vsx_mask-count-runnable.c > @@ -1,7 +1,7 @@ > /* { dg-do run { target { power10_hw } } } */ > /* { dg-do link { target { ! power10_hw } } } */ > /* { dg-options "-mcpu=power10 -O2" } */ > -/* { dg-require-effective-target power10_ok } */ > +/* { dg-require-effective-target { int128 && power10_ok } } */ Or write it as two require statements, as we do most of the time? Okay for trunk (with those tweaks if you want). Thanks! Segher