From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 8B0C73857020 for ; Fri, 30 Oct 2020 11:40:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8B0C73857020 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-366-Hu5alx1BNEqGfUJTaww4yQ-1; Fri, 30 Oct 2020 07:40:09 -0400 X-MC-Unique: Hu5alx1BNEqGfUJTaww4yQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 98D951882FA8; Fri, 30 Oct 2020 11:40:08 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-113-127.ams2.redhat.com [10.36.113.127]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3B32719650; Fri, 30 Oct 2020 11:40:07 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 09UBe4KU1749623 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 30 Oct 2020 12:40:04 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 09UBe2fQ1749622; Fri, 30 Oct 2020 12:40:02 +0100 Date: Fri, 30 Oct 2020 12:40:02 +0100 From: Jakub Jelinek To: Thomas Schwinge Cc: Rainer Orth , Mike Stump , gcc-patches@gcc.gnu.org, Tom de Vries , David Malcolm , Jeff Law Subject: Re: [RFC, testsuite] Add dg-save-linenr Message-ID: <20201030114002.GQ3788@tucnak> Reply-To: Jakub Jelinek References: <1493047222.9106.82.camel@redhat.com> <464d854a-3387-ca8f-86bb-54cfc9da8767@mentor.com> <9feb5b24-5ba2-4316-c8d1-012d5a297029@mentor.com> <877dr8gd5q.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 In-Reply-To: <877dr8gd5q.fsf@euler.schwinge.homeip.net> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Oct 2020 11:40:15 -0000 On Fri, Oct 30, 2020 at 12:34:57PM +0100, Thomas Schwinge wrote: > Hi! > > On 2017-05-22T18:55:29+0200, Tom de Vries wrote: > > On 05/16/2017 03:12 PM, Rainer Orth wrote: > >> [...], but the new proc ['dg-line'] needs documenting in sourcebuild.texi. > > > > Attached patch adds the missing documentation. > > OK to expand that with the attached patch to "Document that 'linenumvar' > in 'dg-line' may contain Tcl syntax"? (Hooray for embedded Tcl! -- > Don't hurt me; I (later) have a use case where this does make things > easier.) Is it desirable though? I mean if we ever decide to switch from dejagnu to something else, adding parsing of our dg-* grammar is not that hard, and while we rely on some tcl details already (e.g. the {}s vs. ""s for regular expressions etc.), allowing arbitrary embedded tcl will make that effort even harder. Jakub