From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 236063842439 for ; Tue, 3 Nov 2020 08:25:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 236063842439 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-476-_WSPikwKPTyYrxq0gHOpjw-1; Tue, 03 Nov 2020 03:25:45 -0500 X-MC-Unique: _WSPikwKPTyYrxq0gHOpjw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0A8CB186840A; Tue, 3 Nov 2020 08:25:44 +0000 (UTC) Received: from localhost (unknown [10.33.36.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id B035F672C0; Tue, 3 Nov 2020 08:25:43 +0000 (UTC) Date: Tue, 3 Nov 2020 08:25:42 +0000 From: Jonathan Wakely To: =?iso-8859-1?Q?Fran=E7ois?= Dumont Cc: "libstdc++@gcc.gnu.org" , gcc-patches Subject: Re: [PATCH] Add missing gnu-versioned-namespace symbols Message-ID: <20201103082542.GV503596@redhat.com> References: <20201102141735.GS503596@redhat.com> <9c81c091-497e-2e36-a855-ce88fc91fdf9@gmail.com> MIME-Version: 1.0 In-Reply-To: <9c81c091-497e-2e36-a855-ce88fc91fdf9@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2020 08:26:06 -0000 On 02/11/20 21:52 +0100, François Dumont via Libstdc++ wrote: >On 02/11/20 3:17 pm, Jonathan Wakely wrote: >>On 01/11/20 20:48 +0100, François Dumont via Libstdc++ wrote: >>>Several tests are failing because of those missing symbols. >>> >>>I understand why we need to export symbols relying in the >>>versioned namespace but I don't understand why we need to do it >>>for _GLIBCXX_DEBUG symbols which are not version namespace >>>dependant. >> >>If you don't export the symbol, it can't be found by code linking to >>libstdc++.so.8 > >So I understand that in versioned namespace mode only >gnu-versioned-namespace.ver is being used and not gnu.ver. Right. >> >>This linker script is the only one used to build libstdc++.so.8 so all >>symbols that need to be exported by that library have to be exported >>by this script. Nothing exports that debug symbol unless you add it >>here. >> >>What I don't understand is why the __istream_extract symbol isn't >>matched by the wildcard in the extern "C++" block at the top of the >>file. > >Maybe for the same reason that the std::__copy_streambufs before this >one and some others symbols in std::__8 had to be explicitely exported >too. > >But I don't know it. Yeah, I don't understand those either. OK for trunk anyway. I'll investigate another day.