From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 987923858012 for ; Tue, 3 Nov 2020 08:31:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 987923858012 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-385-8B10KFMEMv6gi4Gf0UQiWA-1; Tue, 03 Nov 2020 03:30:59 -0500 X-MC-Unique: 8B10KFMEMv6gi4Gf0UQiWA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AB5B957207; Tue, 3 Nov 2020 08:30:58 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-113-127.ams2.redhat.com [10.36.113.127]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 37F136EF57; Tue, 3 Nov 2020 08:30:57 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.16.1/8.16.1) with ESMTPS id 0A38UsXp056933 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 3 Nov 2020 09:30:55 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.16.1/8.16.1/Submit) id 0A38Ur8Z056932; Tue, 3 Nov 2020 09:30:53 +0100 Date: Tue, 3 Nov 2020 09:30:53 +0100 From: Jakub Jelinek To: Olivier Hainque Cc: GCC Patches Subject: Re: [patch] i386 tests: Add dg-require-effective-target fpic to gcc.target/i386 tests Message-ID: <20201103083053.GM3788@tucnak> Reply-To: Jakub Jelinek References: <9FFB6F0E-EDAF-419B-9D1D-FACA9E8896E0@adacore.com> MIME-Version: 1.0 In-Reply-To: <9FFB6F0E-EDAF-419B-9D1D-FACA9E8896E0@adacore.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2020 08:31:03 -0000 On Tue, Nov 03, 2020 at 09:25:03AM +0100, Olivier Hainque wrote: > Hello, > > This change is a proposal to add > > /* { dg-require-effective-target fpic } */ > > to tests in gcc.target/i386 that do use -fpic or -fPIC > but don't currently query the target support. > > This corresponds to what many other fpic tests do > and helps the vxWorks ports at least, as -fpic is > typically not supported in at least one of the two > major modes of such port (kernel vs RTP). 70% of the tests you've changed have a target *-linux* or similar right above that line, what is the point of adding the fpic effective targets to those? Those surely aren't run on vxWorks and on x86 Linux fpic is always supported. No objection to adding it to the rest. Jakub