From: Jakub Jelinek <jakub@redhat.com>
To: Olivier Hainque <hainque@adacore.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch] i386 tests: Add dg-require-effective-target fpic to gcc.target/i386 tests
Date: Tue, 3 Nov 2020 11:25:41 +0100 [thread overview]
Message-ID: <20201103102541.GN3788@tucnak> (raw)
In-Reply-To: <F7E895B2-EF39-46CC-9307-3D6B00EEAEE3@adacore.com>
On Tue, Nov 03, 2020 at 11:24:24AM +0100, Olivier Hainque wrote:
>
>
> > On 3 Nov 2020, at 09:30, Jakub Jelinek <jakub@redhat.com> wrote:
>
> > 70% of the tests you've changed have a target *-linux* or similar
> > right above that line, what is the point of adding the fpic
> > effective targets to those? Those surely aren't run on vxWorks
> > and on x86 Linux fpic is always supported.
>
> Good point. We had quite a few actual failures
> and I did a pretty systematic search, missing the
> linux implication.
>
> > No objection to adding it to the rest.
>
> Ok, amended change below.
>
> Thanks for your prompt feedback on this Jakub!
Ok, thanks.
> 2020-11-03 Olivier Hainque <hainque@adacore.com>
>
> gcc/testsuite/
>
> * gcc.target/i386/pr45352-1.c: Add dg-require-effective-target fpic.
> * gcc.target/i386/pr47602.c: Likewise.
> * gcc.target/i386/pr55151.c: Likewise.
> * gcc.target/i386/pr55458.c: Likewise.
> * gcc.target/i386/pr56348.c: Likewise.
> * gcc.target/i386/pr57097.c: Likewise.
> * gcc.target/i386/pr65753.c: Likewise.
> * gcc.target/i386/pr65915.c: Likewise.
> * gcc.target/i386/pr66232-5.c: Likewise.
> * gcc.target/i386/pr66334.c: Likewise.
> * gcc.target/i386/pr66819-2.c: Likewise.
> * gcc.target/i386/pr67265.c: Likewise.
> * gcc.target/i386/pr81481.c: Likewise.
> * gcc.target/i386/pr83994.c: Likewise.
Jakub
next prev parent reply other threads:[~2020-11-03 10:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 8:25 Olivier Hainque
2020-11-03 8:30 ` Jakub Jelinek
2020-11-03 10:24 ` Olivier Hainque
2020-11-03 10:25 ` Jakub Jelinek [this message]
2020-11-03 11:56 ` Olivier Hainque
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103102541.GN3788@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hainque@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).